Skip to content

gh-128550: TaskGroup: cancel tasks added to set after aborting #128551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
graingert wants to merge 13 commits into from
Closed

gh-128550: TaskGroup: cancel tasks added to set after aborting #128551

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9726c3d
gh-128550: TaskGroup: cancel tasks added to set after aborting
graingert Jan 6, 2025
98b6d01
add test
graingert Jan 6, 2025
f983834
Update Lib/asyncio/taskgroups.py
graingert Jan 6, 2025
6f661be
Update Lib/test/test_asyncio/test_taskgroups.py
graingert Jan 6, 2025
ca5593b
Merge branch 'main' into fix-taskgroup-eager
graingert Jan 6, 2025
1f3e028
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 6, 2025
dfdee7d
Merge branch 'main' into fix-taskgroup-eager
graingert Jan 6, 2025
b1d15b6
Update Lib/test/test_asyncio/test_taskgroups.py
graingert Jan 6, 2025
b3a20db
Apply suggestions from code review
graingert Jan 6, 2025
b777cf4
Update Misc/NEWS.d/next/Library/2025-01-06-18-58-07.gh-issue-128550.l…
graingert Jan 6, 2025
b09c9e0
Merge branch 'main' into fix-taskgroup-eager
graingert Jan 7, 2025
58445e7
Merge branch 'main' into fix-taskgroup-eager
graingert Jan 7, 2025
c4842d9
Merge branch 'main' into fix-taskgroup-eager
graingert Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-128550: TaskGroup: cancel tasks added to set after aborting
  • Loading branch information
@graingert
graingert committed Jan 6, 2025
commit 9726c3d31f4290c164fd0f8a05e4c739817d7256
2 changes: 2 additions & 0 deletions Lib/asyncio/taskgroups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,8 @@ def create_task(self, coro, *, name=None, context=None):
else:
self._tasks.add(task)
task.add_done_callback(self._on_task_done)
if self._aborting:
Comment thread
graingert marked this conversation as resolved.
task.cancel()
return task

# Since Python 3.8 Tasks propagate all exceptions correctly,
Expand Down