Skip to content

GH-128375: Better instrument for FOR_ITER #128445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 9 commits into from
Jan 6, 2025
Merged

GH-128375: Better instrument for FOR_ITER #128445

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
76b9b3e
Speedup instrumented for loops and fix branch iterator bug
markshannon Dec 31, 2024
182c512
Add test for co_branches
markshannon Dec 31, 2024
59bedbd
Fix editing glitch
markshannon Jan 3, 2025
29da92e
PEP 8
markshannon Jan 3, 2025
511733c
Add no_save_ip annotation to indicate that an instruction shouldn't s…
markshannon Jan 3, 2025
592e328
Update assert
markshannon Jan 3, 2025
6b903b3
Fix handling of branch events not from source instruction
markshannon Jan 3, 2025
1c38d89
Ensure consistency between BRANCH event offsets and co_branches.
markshannon Jan 3, 2025
cbe6c7c
Flags should be unsigned
markshannon Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix editing glitch
  • Loading branch information
@markshannon
markshannon committed Jan 3, 2025
commit 59bedbdda52d299dc24cc5ca20afcd6171db4b2b
2 changes: 1 addition & 1 deletion Python/bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ dummy_func(

tier1 inst(INSTRUMENTED_END_FOR, (receiver, value -- receiver)) {
/* Need to create a fake StopIteration error here,
// * to conform to PEP 380 ED_NO*/
* to conform to PEP 380 */
if (PyStackRef_GenCheck(receiver)) {
int err = monitor_stop_iteration(tstate, frame, this_instr, PyStackRef_AsPyObjectBorrow(value));
if (err) {
Expand Down
2 changes: 1 addition & 1 deletion Python/generated_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.