Skip to content

gh-128388: pyrepl on Windows: add meta and ctrl+arrow keybindings #128389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 10 commits into from
Jan 10, 2025
+27 −16
Merged

gh-128388: pyrepl on Windows: add meta and ctrl+arrow keybindings #128389

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
283e7c3
pyrepl on Windows: add meta and ctrl+arrow keybindings
paulie4 Jan 1, 2025
d3df8a2
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 1, 2025
459b379
`2025-01-01-19-24-43.gh-issue-128388.8UdMz_.rst`: fix typo
paulie4 Jan 1, 2025
abe1f62
lint fix `Misc/NEWS.d/next/Library/2025-01-01-19-24-43.gh-issue-12838…
paulie4 Jan 2, 2025
3d07c34
`Lib/_pyrepl/windows_console.py`: temp var `ctrlstate` is not needed
paulie4 Jan 4, 2025
16f2a13
`Lib/_pyrepl/windows_console.py`: clearer comment
paulie4 Jan 4, 2025
e3f6438
PR suggestions
paulie4 Jan 4, 2025
46b22d1
`Lib\_pyrepl\windows_console.py`: fix `Alt`+`←` handling
paulie4 Jan 4, 2025
55e4fbf
`Lib/_pyrepl/windows_console.py`: standardize `Ctrl`+special key
paulie4 Jan 5, 2025
d117d52
Merge branch 'main' into fix-issue-128388
paulie4 Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lib/_pyrepl/windows_console.py: temp var ctrlstate is not needed 
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
  • Loading branch information
@paulie4 @eendebakpt
paulie4 and eendebakpt authored Jan 4, 2025
commit 3d07c340979c8712756769c2bc7aeac325e2e2f4
2 changes: 1 addition & 1 deletion Lib/_pyrepl/windows_console.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ def get_event(self, block: bool = True) -> Event | None:

return None

if (ctrlstate := key_event.dwControlKeyState) and ctrlstate & ALT_ACTIVE:
if key_event.dwControlKeyState & ALT_ACTIVE:
# first send meta, then send the key
Comment thread
paulie4 marked this conversation as resolved.
Outdated
self.event_queue.insert(0, Event(evt="key", data=key, raw=raw_key))
return Event(evt="key", data="\033") # keymap.py uses this for meta
Comment thread
paulie4 marked this conversation as resolved.
Expand Down