gh-128345: GIL is not properly disabled for _freeze_module.vcxproj#128344
Conversation
ZeroIntensity
left a comment
There was a problem hiding this comment.
Are we able to add some sort of test?
|
It hardly matters for this tool. If it's somehow going to help the people working on free-threading to have it enabled for a build time tool, then sure. But there's no reason to backport it. Nobody is developing free-threading in 3.13 anymore - they're all working in |
ZeroIntensity
left a comment
There was a problem hiding this comment.
Thanks for the clarification, LGTM.
|
!buildbot nogil windows |
|
The regex 'nogil windows' did not match any buildbot builder. Is the requested builder in the list of stable builders? |
|
!buildbot windows nogil |
|
The regex 'windows nogil' did not match any buildbot builder. Is the requested builder in the list of stable builders? |
|
!buildbot nogil |
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit cf12bef 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
The _freeze_module.vcxproj file is looking for
#undef Py_GIL_DISABLED, but that was changed to/* #define Py_GIL_DISABLED 1 */some time ago, so the build system ends up looking to replace a line that doesn't exist, the result is that the freeze Python never has GIL disabled even if it was requested during the build