Skip to content

bpo-35967: Baseline values for uname -p#12824

Merged
jaraco merged 4 commits into
python:masterfrom
jaraco:feature/35967-uname-processor-baseline-tests
Apr 15, 2020
Merged

bpo-35967: Baseline values for uname -p#12824
jaraco merged 4 commits into
python:masterfrom
jaraco:feature/35967-uname-processor-baseline-tests

Conversation

@jaraco
Copy link
Copy Markdown
Member

@jaraco jaraco commented Apr 14, 2019 •
edited by bedevere-bot
Loading

As requested in the ticket, I'm working to define the expected values for uname -p.

https://bugs.python.org/issue35967

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Apr 14, 2019
jaraco added 3 commits April 14, 2019 09:42
@jaraco
Instead of trying to keep track of all of the possible outputs on dif…
aa29701 
…ferent systems (probably a fool's errand), simply assert that except for the known platform variance, uname().processor matches the output of 'uname -p'
@jaraco
Use a skipIf directive
01ac684
@jaraco
Use contextlib.suppress to suppress the error. Inline strip call.
9df8602
@jaraco jaraco changed the title WIP: bpo-35967: Baseline values for uname -p bpo-35967: Baseline values for uname -p Apr 14, 2019
@csabella csabella requested a review from malemburg June 1, 2019 15:15
@jaraco
Copy link
Copy Markdown
Member Author

jaraco commented Apr 15, 2020

No sense letting this linger indefinitely. Let's merge the test and push forward.

@jaraco jaraco merged commit 4b4e90a into python:master Apr 15, 2020
@jaraco jaraco deleted the feature/35967-uname-processor-baseline-tests branch April 15, 2020 18:32
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 15, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Debian 3.x has failed when building commit 4b4e90a.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/105/builds/779) and take a look at the build logs.
  4. Check if the failure is related to this commit (4b4e90a) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/105/builds/779

Failed tests:

  • test_platform

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

407 tests OK.

10 slowest tests:

  • test_concurrent_futures: 3 min 2 sec
  • test_multiprocessing_spawn: 2 min 38 sec
  • test_unparse: 1 min 51 sec
  • test_gdb: 1 min 50 sec
  • test_multiprocessing_forkserver: 1 min 35 sec
  • test_tokenize: 1 min 29 sec
  • test_capi: 1 min 27 sec
  • test_multiprocessing_fork: 1 min 17 sec
  • test_lib2to3: 1 min 5 sec
  • test_asyncio: 1 min 1 sec

1 test failed:
test_platform

13 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

1 re-run test:
test_platform

Total duration: 6 min 20 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Lib/test/test_platform.py", line 172, in test_uname_processor
    self.assertEqual(
AssertionError: '' != 'unknown'
+ unknown

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 15, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Arch Linux TraceRefs 3.x has failed when building commit 4b4e90a.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/312/builds/436) and take a look at the build logs.
  4. Check if the failure is related to this commit (4b4e90a) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/312/builds/436

Failed tests:

  • test_platform

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

407 tests OK.

10 slowest tests:

  • test_concurrent_futures: 2 min 32 sec
  • test_multiprocessing_spawn: 1 min 51 sec
  • test_multiprocessing_forkserver: 1 min 18 sec
  • test_subprocess: 1 min 17 sec
  • test_tokenize: 1 min 9 sec
  • test_multiprocessing_fork: 1 min 5 sec
  • test_unparse: 1 min 2 sec
  • test_capi: 57.4 sec
  • test_asyncio: 56.8 sec
  • test_lib2to3: 48.6 sec

1 test failed:
test_platform

13 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

1 re-run test:
test_platform

Total duration: 14 min 41 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/Lib/test/test_platform.py", line 172, in test_uname_processor
    self.assertEqual(
AssertionError: '' != 'unknown'
+ unknown

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 15, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian PGO 3.x has failed when building commit 4b4e90a.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/38/builds/748) and take a look at the build logs.
  4. Check if the failure is related to this commit (4b4e90a) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/38/builds/748

Failed tests:

  • test_platform

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

406 tests OK.

10 slowest tests:

  • test_concurrent_futures: 2 min 42 sec
  • test_multiprocessing_spawn: 1 min 46 sec
  • test_multiprocessing_forkserver: 1 min 17 sec
  • test_multiprocessing_fork: 1 min 9 sec
  • test_signal: 51.0 sec
  • test_asyncio: 47.4 sec
  • test_largefile: 37.4 sec
  • test_tokenize: 37.3 sec
  • test_io: 36.6 sec
  • test_unparse: 32.1 sec

1 test failed:
test_platform

14 tests skipped:
test_devpoll test_gdb test_ioctl test_kqueue test_msilib
test_ossaudiodev test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_platform

Total duration: 11 min 26 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/var/lib/buildbot/workers/enable-optimizations-bot/3.x.gps-debian-profile-opt.pgo/build/Lib/test/test_platform.py", line 172, in test_uname_processor
    self.assertEqual(
AssertionError: '' != 'unknown'
+ unknown

@jaraco jaraco mentioned this pull request Apr 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malemburg malemburg Awaiting requested review from malemburg

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaraco @bedevere-bot @the-knights-who-say-ni