Skip to content

gh-111178: fix UBSan failures in _elementtree.c #127982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 8 commits into from
Dec 16, 2024
Merged

gh-111178: fix UBSan failures in _elementtree.c #127982

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f3b8625
Fix UBSan failures in `xml.etree.ElementTree.Element`
picnixz Dec 16, 2024
26a172c
Fix UBSan failures in `_elementtree._element_iterator`
picnixz Dec 16, 2024
52fdab1
Fix UBSan failures in `xml.etree.ElementTree.TreeBuilder`
picnixz Dec 16, 2024
9ba4c17
Fix UBSan failures in `xml.etree.ElementTree.XMLParser`
picnixz Dec 16, 2024
19df9ba
suppress unused return value
picnixz Dec 16, 2024
bfe7fdd
use 'op' instead of 'PTR' in cast macros
picnixz Dec 16, 2024
d1b2d52
reduce diff
picnixz Dec 16, 2024
766a448
reduce diff
picnixz Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
reduce diff
  • Loading branch information
@picnixz
picnixz committed Dec 16, 2024
commit 766a4481130b5396c12c058edd3ba352cafc8c46
5 changes: 2 additions & 3 deletions Modules/_elementtree.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2511,12 +2511,11 @@ treebuilder_gc_clear(PyObject *op)
}

static void
treebuilder_dealloc(PyObject *op)
treebuilder_dealloc(PyObject *self)
{
TreeBuilderObject *self = _TreeBuilder_CAST(op);
PyTypeObject *tp = Py_TYPE(self);
PyObject_GC_UnTrack(self);
(void)treebuilder_gc_clear(op);
(void)treebuilder_gc_clear(self);
tp->tp_free(self);
Py_DECREF(tp);
}
Expand Down