Skip to content

gh-127298: Refactor test_hashlib for better usedforsecurity & openssl fips mode env support. #127492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gpshead wants to merge 8 commits into
base: main
Choose a base branch
from
Open

gh-127298: Refactor test_hashlib for better usedforsecurity & openssl fips mode env support. #127492

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
59d9a85
Refactor test_hashlib for better usedforsecurity & openssl fips mode …
gpshead Dec 1, 2024
bd46651
More hashlib robustness in strange "FIPS mode" environments.
gpshead Dec 1, 2024
29a2012
remove some obsolete comments
gpshead Dec 2, 2024
e2bf70c
remove debug print
gpshead Dec 2, 2024
3f69411
docs typo
gpshead Dec 2, 2024
2a5b7e8
remove unnecessary as in except statement,
gpshead Dec 2, 2024
a6a75d6
More details in NEWS
gpshead Dec 2, 2024
3f9ec82
news typo
gpshead Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unnecessary as in except statement, 
Co-authored-by: Victor Stinner <vstinner@python.org>
  • Loading branch information
@gpshead @vstinner
gpshead and vstinner authored Dec 2, 2024
commit 2a5b7e8333de2d0798c9aac1fef2ea4a889c3707
2 changes: 1 addition & 1 deletion Lib/hashlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ def file_digest(fileobj, digest, /, *, _bufsize=2**18):
# version not supporting that algorithm.
try:
globals()[__func_name] = __get_hash(__func_name)
except ValueError as exc:
except ValueError:
# Errors logged here would be seen as noise by most people.
# Code using a missing hash will get an obvious exception.
__all__.remove(__func_name)
Expand Down