Skip to content

gh-127443: add tool for linting Doc/data/refcounts.dat#127476

Closed
picnixz wants to merge 32 commits into
python:mainfrom
picnixz:tools/refcounts/lint-127443
Closed

gh-127443: add tool for linting Doc/data/refcounts.dat#127476
picnixz wants to merge 32 commits into
python:mainfrom
picnixz:tools/refcounts/lint-127443

Conversation

@picnixz

@picnixz picnixz commented Dec 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This tool can be used as follows:

python3.12 Tools/refcounts/lint.py  Doc/data/refcounts.dat
python3.12 Tools/refcounts/lint.py  Doc/data/refcounts.dat --abi Misc/stable_abi.toml

With the current file, I have something like: (three were missing in #127451, my bad, so I fixed them as well)

----------------------------------- PARSING ------------------------------------
----------------------------------- CHECKING -----------------------------------
  643  PyErr_NormalizeException[exc]                      missing reference count management
  644  PyErr_NormalizeException[val]                      missing reference count management
  645  PyErr_NormalizeException[tb]                       missing reference count management

Found 3 issues
Entries are not sorted

When I also include the stable ABI file, I have in addition (output truncated)

Found 3 issues
Entries are not sorted
----------------------------- CHECKING STABLE ABI ------------------------------
Stable ABI file: /home/picnix/lib/python/cpython/Misc/stable_abi.toml

Missing 232 stable ABI entries:
PyArg_Parse
PyArg_ParseTuple
PyArg_ParseTupleAndKeywords
PyArg_UnpackTuple
PyArg_VaParse
PyArg_VaParseTupleAndKeywords
PyArg_ValidateKeywordArguments
PyBuffer_FromContiguous
[...]

@bedevere-app bedevere-app Bot mentioned this pull request Dec 1, 2024
Open
@picnixz picnixz force-pushed the tools/refcounts/lint-127443 branch from bc45547 to 183388f Compare December 1, 2024 12:29
Eclips4
Eclips4 reviewed Dec 1, 2024
View reviewed changes
Comment thread Tools/refcounts/lint.py Outdated
ZeroIntensity
ZeroIntensity reviewed Dec 1, 2024
View reviewed changes
Comment thread Tools/refcounts/lint.py Outdated
ZeroIntensity
ZeroIntensity reviewed Dec 1, 2024
View reviewed changes
Comment thread Tools/refcounts/lint.py Outdated
Comment thread Tools/refcounts/lint.py Outdated
Comment thread Tools/refcounts/lint.py Outdated
Comment thread Tools/refcounts/lint.py Outdated
Comment thread Tools/refcounts/lint.py Outdated
AlexWaygood
AlexWaygood reviewed Dec 1, 2024
View reviewed changes
Comment thread Tools/refcounts/.ruff.toml Outdated
Comment thread Tools/refcounts/mypy.ini Outdated
AlexWaygood
AlexWaygood reviewed Dec 1, 2024
View reviewed changes
Comment thread Tools/refcounts/.ruff.toml Outdated
AlexWaygood
AlexWaygood reviewed Dec 1, 2024
View reviewed changes
Comment thread Tools/refcounts/lint.py Outdated
Comment thread Tools/refcounts/lint.py Outdated
Comment thread Tools/refcounts/lint.py Outdated
AlexWaygood
AlexWaygood reviewed Dec 2, 2024
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I haven't reviewed the script as I know nothing about the refcounts.dat file, but the lint configs LGTM.

Comment thread Tools/refcounts/.ruff.toml Outdated
@picnixz

picnixz commented Dec 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

I don't think I'll change the configs. So thanks Alex for your review (and sorry for the request, I misclicked)! Now, I'll wait for Peter and Kirill's reviews concerning the script itself.

@AlexWaygood AlexWaygood removed their request for review December 2, 2024 12:10
ZeroIntensity
ZeroIntensity reviewed Dec 2, 2024
View reviewed changes
Comment thread Tools/refcounts/lint.py Outdated
Comment thread Tools/refcounts/lint.py Outdated
Comment thread Tools/refcounts/lint.py Outdated
Comment thread Tools/refcounts/lint.py Outdated
hugovk
hugovk reviewed Dec 2, 2024
View reviewed changes
Comment thread .github/workflows/mypy.yml
AlexWaygood
AlexWaygood reviewed Dec 2, 2024
View reviewed changes
Comment thread Tools/refcounts/lint.py Outdated
@picnixz picnixz added the stale Stale PR or inactive for long period of time. label Mar 31, 2025
@picnixz

picnixz commented Mar 31, 2025

Copy link
Copy Markdown
Member Author

Marking it as stale because I still didn't have time to work on the project separately (I'm working on it but I'm advancing slowly)

@picnixz picnixz marked this pull request as draft March 31, 2025 09:33
@picnixz

picnixz commented Feb 7, 2026

Copy link
Copy Markdown
Member Author

Considering I haven't been able to work on this one since last year, I'm going to close it. I think @ZeroIntensity wanted to do a similar work so I'll let him do it.

@picnixz picnixz closed this Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments

@AlexWaygood AlexWaygood AlexWaygood left review comments

@Eclips4 Eclips4 Awaiting requested review from Eclips4

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti will be requested when the pull request is marked ready for review ezio-melotti is a code owner

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz will be requested when the pull request is marked ready for review webknjaz is a code owner

@itamaro itamaro Awaiting requested review from itamaro itamaro will be requested when the pull request is marked ready for review itamaro is a code owner

Assignees

No one assigned

Labels

skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@picnixz @hugovk @ZeroIntensity @AlexWaygood @Eclips4