Skip to content

gh-127298: When in FIPS mode ensure builtin hashes check for usedforsecurity=False #127301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xnox wants to merge 13 commits into
base: main
Choose a base branch
from
Open

gh-127298: When in FIPS mode ensure builtin hashes check for usedforsecurity=False #127301

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
21b30a1
gh-127298: When in FIPS mode ensure builtin hashes check for usedfors…
xnox Nov 26, 2024
42b912a
use != 0 rather than == 1 and update a comment.
gpshead Nov 27, 2024
ac9dc6d
Update the NEWS to reflect reality.
gpshead Nov 27, 2024
4da9f77
address _some_ correctness details in the test.
gpshead Nov 27, 2024
7a954ff
avoid repeated calls, reword comment.
gpshead Nov 27, 2024
461920d
Update 2024-11-26-16-31-40.gh-issue-127298.jqYJvn.rst
gpshead Nov 27, 2024
dabed52
avoid rerunning test in refleak hunting mode.
gpshead Nov 27, 2024
57241db
Change to spawn _test_hashlib_fips from test_hashlib with an env.
gpshead Nov 27, 2024
3910723
Use subTest to id the algorithm.
gpshead Nov 27, 2024
e8ef380
lint
gpshead Nov 27, 2024
3db1eb5
remove the no longer appropriate mention from ssltests.
gpshead Nov 27, 2024
4e5dddb
fix subTest context manager nesting.
gpshead Nov 27, 2024
fd308b4
Use null provider, which is guaranteed to have nothing
xnox Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address _some_ correctness details in the test.
  • Loading branch information
@gpshead @xnox
gpshead authored and xnox committed Sep 8, 2025
commit 4da9f775aea3b9553e7a44e55c54183ad73f7f02
8 changes: 6 additions & 2 deletions Lib/test/test_hashlib_fips.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,17 @@
#

import os
import sys
import unittest

OPENSSL_CONF_BACKUP = os.environ.get("OPENSSL_CONF")


class HashLibFIPSTestCase(unittest.TestCase):
@classmethod
def setUpClass(cls):
if sys.modules.get("_hashlib") or sys.modules.get("_ssl"):
raise AssertionError("_hashlib or _ssl already imported, too late to change OPENSSL_CONF.")
Comment thread
gpshead marked this conversation as resolved.
Outdated
# This openssl.cnf mocks FIPS mode without any digest
# loaded. It means all digests must raise ValueError when
# usedforsecurity=True via either openssl or builtin
Expand All @@ -35,10 +39,10 @@ def setUp(self):

@classmethod
def tearDownClass(cls):
if OPENSSL_CONF_BACKUP:
if OPENSSL_CONF_BACKUP is not None:
os.environ["OPENSSL_CONF"] = OPENSSL_CONF_BACKUP
else:
del(os.environ["OPENSSL_CONF"])
os.environ.pop("OPENSSL_CONF", None)

def test_algorithms_available(self):
import hashlib
Expand Down