Skip to content

gh-126220: Adapt _lsprof to Argument Clinic #126233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobolevn merged 10 commits into from
Nov 4, 2024
Merged

gh-126220: Adapt _lsprof to Argument Clinic #126233

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
299f63f
gh-126220: Fix crash on calls to `_lsprof.Profiler` methods with 0 args
sobolevn Oct 31, 2024
af78745
Fix CI
sobolevn Oct 31, 2024
3fddc30
Only fix 4 crashers
sobolevn Oct 31, 2024
4ffecdd
Use `instruction_offset` arg name
sobolevn Oct 31, 2024
2b6ecc9
Merge
sobolevn Nov 1, 2024
e3160e3
Convert all methods
sobolevn Nov 1, 2024
3cea189
Apply suggestions from code review
sobolevn Nov 2, 2024
b84dde3
Address review
sobolevn Nov 2, 2024
bf3e120
Typo
sobolevn Nov 2, 2024
0d35f60
Address review
sobolevn Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
  • Loading branch information
@sobolevn @erlend-aasland
sobolevn and erlend-aasland authored Nov 2, 2024
commit 3cea189c3614618d20a74edf31dece03b3bc00e0
6 changes: 3 additions & 3 deletions Modules/_lsprof.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,11 +940,11 @@ _lsprof.Profiler.__init__
subcalls: bool = True
builtins: bool = True

Builds a profiler object using the specified timer function.
Build a profiler object using the specified timer function.

The default timer is a fast built-in one based on real time.
For custom timer functions returning integers, timeunit can
be a float specifying a scale (i.e. how long each integer unit
For custom timer functions returning integers, 'timeunit' can
be a float specifying a scale (that is, how long each integer unit
is, in seconds).
[clinic start generated code]*/

Expand Down