Skip to content

gh-126012: Add __class_getitem__ to memoryview #126013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobolevn merged 5 commits into from
Oct 27, 2024
Merged

gh-126012: Add __class_getitem__ to memoryview #126013

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2a260d5
Add __class_getitem__ to memoryview
brianschubert Oct 26, 2024
6f02b08
Update Doc/whatsnew/3.14.rst
brianschubert Oct 26, 2024
19c36da
Update Misc/NEWS.d/next/Core and Builtins/2024-10-26-13-32-48.gh-issu…
brianschubert Oct 26, 2024
b78ab6b
Add versionchanged directive to memoryview docs
brianschubert Oct 26, 2024
413fa83
Update Doc/library/stdtypes.rst
brianschubert Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add __class_getitem__ to memoryview
  • Loading branch information
@brianschubert
brianschubert committed Oct 26, 2024
commit 2a260d50ab11d93c8adcc5cef2636013dc7d742f
3 changes: 3 additions & 0 deletions Doc/whatsnew/3.14.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,9 @@ Other language changes
:mod:`copyable <copy>`.
(Contributed by Serhiy Storchaka in :gh:`125767`.)

* The :class:`memoryview` type now supports subscripting, making it a
:term:`generic type`. (Contributed by Brian Schubert in :gh:`126012`.)
Comment thread
brianschubert marked this conversation as resolved.
Outdated


New modules
===========
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_genericalias.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@

class BaseTest(unittest.TestCase):
"""Test basics."""
generic_types = [type, tuple, list, dict, set, frozenset, enumerate,
generic_types = [type, tuple, list, dict, set, frozenset, enumerate, memoryview,
defaultdict, deque,
SequenceMatcher,
dircmp,
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2024-10-26-13-32-48.gh-issue-126012.2KalhG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
The :class:`memoryview` type now supports subscripting, making it a
Comment thread
brianschubert marked this conversation as resolved.
Outdated
:term:`generic type`.
1 change: 1 addition & 0 deletions Objects/memoryobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3286,6 +3286,7 @@ static PyMethodDef memory_methods[] = {
MEMORYVIEW__FROM_FLAGS_METHODDEF
{"__enter__", memory_enter, METH_NOARGS, NULL},
{"__exit__", memory_exit, METH_VARARGS, memory_exit_doc},
{"__class_getitem__", Py_GenericAlias, METH_O|METH_CLASS, PyDoc_STR("See PEP 585")},
{NULL, NULL}
};

Expand Down