Skip to content

gh-124694: In test_interpreter_pool, Restore the Asyncio Event Loop Policy During Cleanup #125708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 4 commits into from
Oct 18, 2024
Merged

gh-124694: In test_interpreter_pool, Restore the Asyncio Event Loop Policy During Cleanup #125708

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
af52044
Clear the default event loop policy if it might have been set.
ericsnowcurrently Oct 18, 2024
b0519f9
Move the cleanup to the class teardown.
ericsnowcurrently Oct 18, 2024
216cc99
Add a comment about clearing the policy.
ericsnowcurrently Oct 18, 2024
0f6c50f
Update Lib/test/test_concurrent_futures/test_interpreter_pool.py
ericsnowcurrently Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move the cleanup to the class teardown.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Oct 18, 2024
commit b0519f9a2818277c3e40649f835a512c8ed15d47
12 changes: 9 additions & 3 deletions Lib/test/test_concurrent_futures/test_interpreter_pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,15 @@ def test_idle_thread_reuse(self):

class AsyncioTest(InterpretersMixin, testasyncio_utils.TestCase):

@classmethod
def setUpClass(cls):
policy = support.maybe_get_event_loop_policy()
assert policy is None, policy

@classmethod
def tearDownClass(cls):
asyncio.set_event_loop_policy(None)

Comment thread
ZeroIntensity marked this conversation as resolved.
def setUp(self):
super().setUp()
self.loop = asyncio.new_event_loop()
Expand All @@ -290,9 +299,6 @@ def setUp(self):
self.executor = self.executor_type()
self.addCleanup(lambda: self.executor.shutdown())

if support.maybe_get_event_loop_policy() is None:
self.addCleanup(lambda: asyncio.set_event_loop_policy(None))

def tearDown(self):
if not self.loop.is_closed():
testasyncio_utils.run_briefly(self.loop)
Expand Down