Skip to content

gh-85935: Explicitly document the case nargs=0 in argparse#125302

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:argparse-nargs-0-docs
Oct 12, 2024
Merged

gh-85935: Explicitly document the case nargs=0 in argparse#125302
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:argparse-nargs-0-docs

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Oct 11, 2024

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Oct 11, 2024
@savannahostrowski savannahostrowski changed the title gh-85935: Excplicitly document the case nargs=0 in argparse gh-85935: Explicitly document the case nargs=0 in argparse Oct 11, 2024

@savannahostrowski savannahostrowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments for conciseness, but otherwise, LGTM.

Comment thread Doc/library/argparse.rst Outdated
Comment thread Doc/library/argparse.rst Outdated
Co-authored-by: Savannah Ostrowski <savannahostrowski@gmail.com>
@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) October 12, 2024 11:35
@serhiy-storchaka serhiy-storchaka merged commit 07c2d15 into python:main Oct 12, 2024
@miss-islington-app

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 12, 2024
…honGH-125302)

(cherry picked from commit 07c2d15)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 12, 2024
…honGH-125302)

(cherry picked from commit 07c2d15)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app

bedevere-app Bot commented Oct 12, 2024

Copy link
Copy Markdown

GH-125357 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Oct 12, 2024
@bedevere-app

bedevere-app Bot commented Oct 12, 2024

Copy link
Copy Markdown

GH-125358 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 12, 2024
serhiy-storchaka added a commit that referenced this pull request Oct 12, 2024
…-125302) (GH-125358)

(cherry picked from commit 07c2d15)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Oct 12, 2024
…-125302) (GH-125357)

(cherry picked from commit 07c2d15)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka deleted the argparse-nargs-0-docs branch October 21, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants