Skip to content

GH-125174: Make immortal objects more robust, following design from PEP 683 #125251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 4 commits into from
Oct 10, 2024
Merged

GH-125174: Make immortal objects more robust, following design from PEP 683 #125251

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e932334
Make immortal objects more robust, following design in PEP 683
markshannon Oct 10, 2024
94f8fd0
Add news
markshannon Oct 10, 2024
9f86e46
Remove last uses of _Py_IsImmortalLoose
markshannon Oct 10, 2024
9c76c52
Fixup comment
markshannon Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixup comment
  • Loading branch information
@markshannon
markshannon committed Oct 10, 2024
commit 9c76c52ce608ac86e98b06d6c3715cd7aa3de89c
7 changes: 0 additions & 7 deletions Include/refcount.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,6 @@ cleanup during runtime finalization.
In 64+ bit systems, any object whose 32 bit reference count is >= 2**31
will be treated as immortal.

In order to offer some resilience to C extensions using the stable ABI
compiled against 3.11 or earlier, we set the initial value near the
middle of the range (2**31, 2**32 - 2**29). That way the

will be marked as immortal by setting all of the
lower 32 bits of the reference count field, which is equal to: 0xFFFFFFFF

Using the lower 32 bits makes the value backwards compatible by allowing
C-Extensions without the updated checks in Py_INCREF and Py_DECREF to safely
increase and decrease the objects reference count.
Expand Down