gh-125018: Add importlib.metadata semantic link targets#125027
Merged
ncoghlan merged 6 commits intoOct 7, 2024
Conversation
This allows direct intersphinx references to APIs via references like `` :func:`importlib.metadata.version` ``.
AA-Turner
reviewed
Oct 6, 2024
willingc
reviewed
Oct 6, 2024
webknjaz
reviewed
Oct 6, 2024
webknjaz
reviewed
Oct 6, 2024
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
ncoghlan
commented
Oct 7, 2024
ncoghlan
left a comment
Contributor
Author
There was a problem hiding this comment.
Thanks for the review comments folks. Mostly accepted and included in the latest push, a few more detailed responses inline.
Contributor
Author
|
Thanks for the reviews folks. Merging this to get the link targets added, we can always adjust the docs further in future PRs. |
|
Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
Sorry, @ncoghlan, I could not cleanly backport this to |
|
Sorry, @ncoghlan, I could not cleanly backport this to |
ncoghlan
added a commit
to ncoghlan/cpython
that referenced
this pull request
Oct 7, 2024
…#125027) This allows direct intersphinx references to APIs via references like `` :func:`importlib.metadata.version` ``. --------- Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> (cherry picked from commit cda3b5a)
|
GH-125047 is a backport of this pull request to the 3.13 branch. |
|
GH-125048 is a backport of this pull request to the 3.12 branch. |
Contributor
Author
|
3.12 backport is set to automerge, 3.13 backport merge will have to wait until the branch is unlocked post-3.13.0. |
ncoghlan
added a commit
that referenced
this pull request
Oct 7, 2024
…5027) (#125048) This allows direct intersphinx references to APIs via references like `` :func:`importlib.metadata.version` ``. --------- (cherry picked from commit cda3b5a) Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner
added a commit
that referenced
this pull request
Oct 8, 2024
…5027) (#125047) gh-125018: Add importlib.metadata semantic link targets (#125027) This allows direct intersphinx references to APIs via references like `` :func:`importlib.metadata.version` ``. (cherry picked from commit cda3b5a) --------- Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows direct intersphinx references to APIs via references like
:func:`importlib.metadata.version`.importlibdocumentation doesn't declare functions properly #125018📚 Documentation preview 📚: https://cpython-previews--125027.org.readthedocs.build/