Skip to content

[3.13] GH-124567: Revert the Incremental GC in 3.13 #124770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yhg1s merged 16 commits into from
Sep 30, 2024
Merged

[3.13] GH-124567: Revert the Incremental GC in 3.13 #124770

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
95fe67e
Revert "[3.13] GH-117759: Document incremental GC (GH-123266) (#123395)"
Yhg1s Sep 29, 2024
8e9333e
Revert "[3.13] GH-122298: Restore printing of GC stats (GH-123261) (#…
Yhg1s Sep 29, 2024
3155e44
Revert "gh-117657: TSAN fix race on `gstate->young.count` (#118313)"
Yhg1s Sep 29, 2024
8f60f05
Revert "Silence compiler warnings in gc.c (#117422)"
Yhg1s Sep 29, 2024
2992289
Revert "GH-117108: Set the "old space bit" to "visited" for all young…
Yhg1s Sep 29, 2024
60a248b
Revert "GH-117108: Change the size of the GC increment to about 1% of…
Yhg1s Sep 29, 2024
d15eace
Revert "GH-108362: Incremental Cycle GC (GH-116206)"
Yhg1s Sep 29, 2024
ffcd513
Fix merge snafu in What's New.
Yhg1s Sep 29, 2024
03caeb5
Fix the free-threaded build.
Yhg1s Sep 29, 2024
cff0436
Undo a few revers where there is no harm in the original versions.
Yhg1s Sep 29, 2024
a0d5270
Fix TSan build of freethreaded python.
Yhg1s Sep 29, 2024
1ba3555
Reinstate cast.
Yhg1s Sep 30, 2024
f95093d
Update the ABI.
Yhg1s Sep 30, 2024
6947c05
Incorporate AA Turner's doc update
Yhg1s Sep 30, 2024
f4b14d5
Merge branch '3.13' into 3.13-revert-incremental-gc
Yhg1s Sep 30, 2024
8504cc0
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Silence compiler warnings in gc.c (#117422)" 
This reverts commit ddf814d.
  • Loading branch information
@Yhg1s
Yhg1s committed Sep 29, 2024
commit 8f60f05ca8f348b39b116af6c90fb49eac72d746
3 changes: 0 additions & 3 deletions Python/gc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1316,7 +1316,6 @@ gc_collect_young(PyThreadState *tstate,
survivor_count++;
}
}
(void)survivor_count; // Silence compiler warning
gc_list_merge(&survivors, visited);
validate_old(gcstate);
gcstate->young.count = 0;
Expand All @@ -1329,14 +1328,12 @@ gc_collect_young(PyThreadState *tstate,
add_stats(gcstate, 0, stats);
}

#ifndef NDEBUG
static inline int
IS_IN_VISITED(PyGC_Head *gc, int visited_space)
{
assert(visited_space == 0 || flip_old_space(visited_space) == 0);
return gc_old_space(gc) == visited_space;
}
#endif

struct container_and_flag {
PyGC_Head *container;
Expand Down