Skip to content

gh-124688: _decimal: Get a module state from ctx objects for performance #124691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 6 commits into from
Sep 28, 2024
Merged

gh-124688: _decimal: Get a module state from ctx objects for performance #124691

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7a9fac1
add a getter function
neonene Sep 27, 2024
818c24f
add _dec_mpd_radix()
neonene Sep 27, 2024
00d2322
PyDecType_New, dec_alloc, dec_from_long
neonene Sep 27, 2024
ab5adad
replace related get_module_state_by_def()
neonene Sep 27, 2024
a34f2d3
delete some spaces
neonene Sep 28, 2024
f7dd655
Update Modules/_decimal/_decimal.c
vstinner Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add _dec_mpd_radix()
  • Loading branch information
@neonene
neonene committed Sep 27, 2024
commit 818c24fd2c96d8e1494528397a72c14352be5bd6
15 changes: 11 additions & 4 deletions Modules/_decimal/_decimal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4433,12 +4433,11 @@ dec_conjugate(PyObject *self, PyObject *Py_UNUSED(dummy))
return Py_NewRef(self);
}

static PyObject *
dec_mpd_radix(PyObject *self, PyObject *Py_UNUSED(dummy))
static inline PyObject *
_dec_mpd_radix(decimal_state *state)
{
PyObject *result;

decimal_state *state = get_module_state_by_def(Py_TYPE(self));
result = dec_alloc(state);
if (result == NULL) {
return NULL;
Expand All @@ -4448,6 +4447,13 @@ dec_mpd_radix(PyObject *self, PyObject *Py_UNUSED(dummy))
return result;
}

static PyObject *
dec_mpd_radix(PyObject *self, PyObject *Py_UNUSED(dummy))
{
decimal_state *state = get_module_state_by_def(Py_TYPE(self));
return _dec_mpd_radix(state);
}

static PyObject *
dec_mpd_qcopy_abs(PyObject *self, PyObject *Py_UNUSED(dummy))
{
Expand Down Expand Up @@ -5403,7 +5409,8 @@ DecCtx_TernaryFunc(mpd_qfma)
static PyObject *
ctx_mpd_radix(PyObject *context, PyObject *dummy)
{
return dec_mpd_radix(context, dummy);
decimal_state *state = get_module_state_from_ctx(context);
return _dec_mpd_radix(state);
}

/* Boolean functions: single decimal argument */
Expand Down