Skip to content

GH-124108: Skip test_strcoll_with_diacritic and test_strxfrm_with_diacritic on NetBSD due to lack of UTF-8 LC_COLLATE support#124110

Merged
vstinner merged 2 commits into
python:mainfrom
furkanonder:gh-124108
Sep 16, 2024
Merged

GH-124108: Skip test_strcoll_with_diacritic and test_strxfrm_with_diacritic on NetBSD due to lack of UTF-8 LC_COLLATE support#124110
vstinner merged 2 commits into
python:mainfrom
furkanonder:gh-124108

Conversation

@furkanonder
Copy link
Copy Markdown
Contributor

@furkanonder furkanonder commented Sep 15, 2024 •
edited by bedevere-app Bot
Loading

@furkanonder
Skip test_strcoll_with_diacritic and test_strxfrm_with_diacritic on N…
c4308fd 
…etBSD due to lack of UTF-8 LC_COLLATE support
@furkanonder furkanonder added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 15, 2024
@furkanonder furkanonder changed the title Skip test_strcoll_with_diacritic and test_strxfrm_with_diacritic on NetBSD due to lack of UTF-8 LC_COLLATE support GH-124108: Skip test_strcoll_with_diacritic and test_strxfrm_with_diacritic on NetBSD due to lack of UTF-8 LC_COLLATE support Sep 15, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 15, 2024
Closed
vstinner
vstinner reviewed Sep 16, 2024
View reviewed changes
Comment thread Lib/test/test_locale.py Outdated
Comment thread Lib/test/test_locale.py Outdated
@vstinner vstinner enabled auto-merge (squash) September 16, 2024 21:25
vstinner
vstinner approved these changes Sep 16, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner closed this Sep 16, 2024
auto-merge was automatically disabled September 16, 2024 22:35

Pull request was closed

@vstinner vstinner reopened this Sep 16, 2024
@vstinner vstinner enabled auto-merge (squash) September 16, 2024 22:36
@vstinner
Copy link
Copy Markdown
Member

vstinner commented Sep 16, 2024

The CI was sick. I closed/reopened the CI to trigger new CI jobs.

@vstinner vstinner merged commit 10de360 into python:main Sep 16, 2024
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented Sep 16, 2024

Thanks @furkanonder for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2024
@furkanonder @miss-islington
pythonGH-124108: Skip test_locale.test_strcoll_with_diacritic() on Ne…
d707a35 
…tBSD (pythonGH-124110)

Skip test_strcoll_with_diacritic() and test_strxfrm_with_diacritic()
of test_locale on NetBSD due to lack of UTF-8 LC_COLLATE
support.
(cherry picked from commit 10de360)

Co-authored-by: Furkan Onder <furkanonder@protonmail.com>
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Sep 16, 2024

GH-124146 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Sep 16, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2024
@furkanonder @miss-islington
pythonGH-124108: Skip test_locale.test_strcoll_with_diacritic() on Ne…
aa244ba 
…tBSD (pythonGH-124110)

Skip test_strcoll_with_diacritic() and test_strxfrm_with_diacritic()
of test_locale on NetBSD due to lack of UTF-8 LC_COLLATE
support.
(cherry picked from commit 10de360)

Co-authored-by: Furkan Onder <furkanonder@protonmail.com>
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Sep 16, 2024

GH-124147 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 16, 2024
vstinner pushed a commit that referenced this pull request Sep 16, 2024
@miss-islington @furkanonder
[3.12] GH-124108: Skip test_locale.test_strcoll_with_diacritic() on N…
2f9dc65 
…etBSD (GH-124110) (#124147)

GH-124108: Skip test_locale.test_strcoll_with_diacritic() on NetBSD (GH-124110)

Skip test_strcoll_with_diacritic() and test_strxfrm_with_diacritic()
of test_locale on NetBSD due to lack of UTF-8 LC_COLLATE
support.
(cherry picked from commit 10de360)

Co-authored-by: Furkan Onder <furkanonder@protonmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 17, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 Refleaks 3.12 has failed when building commit 2f9dc65.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1158/builds/510) and take a look at the build logs.
  4. Check if the failure is related to this commit (2f9dc65) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1158/builds/510

Summary of the results of the build (if available):

Click to see traceback logs 
Note: switching to '2f9dc65e121df86cf5fd25f7830ab7dea129e60f'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 2f9dc65e121 [3.12] GH-124108: Skip test_locale.test_strcoll_with_diacritic() on NetBSD (GH-124110) (#124147)
Switched to and reset branch '3.12'

make: *** [Makefile:2021: buildbottest] Terminated

savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request Sep 22, 2024
@furkanonder @savannahostrowski
pythonGH-124108: Skip test_locale.test_strcoll_with_diacritic() on Ne…
f1c8323 
…tBSD (python#124110)

Skip test_strcoll_with_diacritic() and test_strxfrm_with_diacritic()
of test_locale on NetBSD due to lack of UTF-8 LC_COLLATE
support.
Yhg1s pushed a commit that referenced this pull request Sep 23, 2024
@miss-islington @furkanonder
[3.13] GH-124108: Skip test_locale.test_strcoll_with_diacritic() on N…
3b20303 
…etBSD (GH-124110) (#124146)

GH-124108: Skip test_locale.test_strcoll_with_diacritic() on NetBSD (GH-124110)

Skip test_strcoll_with_diacritic() and test_strxfrm_with_diacritic()
of test_locale on NetBSD due to lack of UTF-8 LC_COLLATE
support.
(cherry picked from commit 10de360)

Co-authored-by: Furkan Onder <furkanonder@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@furkanonder @vstinner @bedevere-bot