Skip to content

[3.12] gh-123811: test that round() can return signed zero (GH-123829) #123939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 2 commits into from
Sep 11, 2024
+5 −5
Merged

[3.12] gh-123811: test that round() can return signed zero (GH-123829) #123939

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0c45be
gh-123811: test that round() can return signed zero (GH-123829)
skirpichev Sep 11, 2024
6364fff
Merge branch '3.12' into backport-d2b9b6f-3.12
vstinner Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-123811: test that round() can return signed zero (GH-123829) 
(cherry picked from commit d2b9b6f)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
  • Loading branch information
@skirpichev @miss-islington
skirpichev authored and miss-islington committed Sep 11, 2024
commit f0c45bed9b865c86b2e6ec681461be4155ba18d9
10 changes: 5 additions & 5 deletions Lib/test/test_float.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,7 +828,7 @@ def test_short_repr(self):
self.assertEqual(repr(float(negs)), str(float(negs)))

@support.requires_IEEE_754
class RoundTestCase(unittest.TestCase):
class RoundTestCase(unittest.TestCase, FloatsAreIdenticalMixin):

def test_inf_nan(self):
self.assertRaises(OverflowError, round, INF)
Expand Down Expand Up @@ -858,10 +858,10 @@ def test_large_n(self):

def test_small_n(self):
for n in [-308, -309, -400, 1-2**31, -2**31, -2**31-1, -2**100]:
self.assertEqual(round(123.456, n), 0.0)
self.assertEqual(round(-123.456, n), -0.0)
self.assertEqual(round(1e300, n), 0.0)
self.assertEqual(round(1e-320, n), 0.0)
self.assertFloatsAreIdentical(round(123.456, n), 0.0)
self.assertFloatsAreIdentical(round(-123.456, n), -0.0)
self.assertFloatsAreIdentical(round(1e300, n), 0.0)
self.assertFloatsAreIdentical(round(1e-320, n), 0.0)

def test_overflow(self):
self.assertRaises(OverflowError, round, 1.6e308, -308)
Expand Down