Skip to content

gh-123919: Fix null handling in _freeze_module.c#123920

Merged
kumaraditya303 merged 1 commit into
python:mainfrom
sobolevn:issue-123919
Sep 11, 2024
Merged

gh-123919: Fix null handling in _freeze_module.c#123920
kumaraditya303 merged 1 commit into
python:mainfrom
sobolevn:issue-123919

Conversation

@sobolevn
Copy link
Copy Markdown
Member

@sobolevn sobolevn commented Sep 10, 2024 •
edited by bedevere-app Bot
Loading

@bedevere-app bedevere-app Bot mentioned this pull request Sep 10, 2024
Closed
@sobolevn sobolevn added skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 10, 2024
vstinner
vstinner approved these changes Sep 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303 kumaraditya303 merged commit c8d1dbe into python:main Sep 11, 2024
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented Sep 11, 2024

Thanks @sobolevn for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2024
@sobolevn @miss-islington
pythongh-123919: Fix null handling in _freeze_module.c (pythonGH-12…
366fc25 
…3920)

(cherry picked from commit c8d1dbe)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Sep 11, 2024

GH-123948 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2024
@sobolevn @miss-islington
pythongh-123919: Fix null handling in _freeze_module.c (pythonGH-12…
2a68356 
…3920)

(cherry picked from commit c8d1dbe)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Sep 11, 2024
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Sep 11, 2024

GH-123949 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 11, 2024
kumaraditya303 pushed a commit that referenced this pull request Sep 11, 2024
@miss-islington @sobolevn
[3.12] gh-123919: Fix null handling in _freeze_module.c (GH-123920) (…
cbfeb6a 
…#123949)

gh-123919: Fix null handling in `_freeze_module.c` (GH-123920)
(cherry picked from commit c8d1dbe)

Co-authored-by: sobolevn <mail@sobolevn.me>
Yhg1s pushed a commit that referenced this pull request Sep 30, 2024
@miss-islington @sobolevn
[3.13] gh-123919: Fix null handling in _freeze_module.c (GH-123920) (…
8b9bd43 
…#123948)

gh-123919: Fix null handling in `_freeze_module.c` (GH-123920)
(cherry picked from commit c8d1dbe)

Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn @vstinner @kumaraditya303