gh-123392: Clarify wording regarding parameters that are functions to be called#123394
Conversation
picnixz
left a comment
There was a problem hiding this comment.
I think this is good because that's how object_pairs_hook and object_hook are documented. Well, personally I would have kept the current wording and only updated those two but I don't mind to be a bit more verbose if needed.
Just waiting for the changes to be done before accepting.
picnixz
left a comment
There was a problem hiding this comment.
One last nitpick: we wrap lines at 80 chars. I don't know whether the RST is now more than 80 chars wide or not but if it's the case, can you make the RST fit on 80 characters? (be careful that your lines do not have trailing whitespaces).
Hey @picnixz -- sure thing, nitpicks welcome! I made the change in da35e8b. Let me know if you see any other way to improve the PR. |
picnixz
left a comment
There was a problem hiding this comment.
I think it's good unless I missed an obvious typo.
|
Thanks @ryan-duve for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…ons to be called (pythonGH-123394) (cherry picked from commit c08ede2) Co-authored-by: ryan-duve <ryan-duve@users.noreply.github.com>
|
GH-123664 is a backport of this pull request to the 3.13 branch. |
…ons to be called (pythonGH-123394) (cherry picked from commit c08ede2) Co-authored-by: ryan-duve <ryan-duve@users.noreply.github.com>
|
GH-123665 is a backport of this pull request to the 3.12 branch. |
Fix for #123392 to clarify wording on callable parameters in documentation.
📚 Documentation preview 📚: https://cpython-previews--123394.org.readthedocs.build/