Skip to content

GH-73991: Disallow copying directory into itself via pathlib.Path.copy() #122924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barneygale merged 9 commits into from
Aug 23, 2024
Merged

GH-73991: Disallow copying directory into itself via pathlib.Path.copy() #122924

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e2b4c6d
GH-73991: Disallow copying directory into itself via `pathlib.Path.co…
barneygale Aug 12, 2024
d646ad2
Tweak import
barneygale Aug 12, 2024
c5a79d0
Expand tests
barneygale Aug 12, 2024
f58c07a
Add comment to _ensure_distinct_path()
barneygale Aug 13, 2024
b119e3d
Improve wording
barneygale Aug 13, 2024
32530b7
Add tests for symlink-to-other-symlink copies.
barneygale Aug 18, 2024
a15f248
Fix windows tests
barneygale Aug 18, 2024
d371b89
More Windows goodness
barneygale Aug 18, 2024
7f5b1ab
Address review feedback
barneygale Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment to _ensure_distinct_path()
  • Loading branch information
@barneygale
barneygale committed Aug 13, 2024
commit f58c07a9fc77584b9faf2b0de3ec2d6cdddffd96
5 changes: 5 additions & 0 deletions Lib/pathlib/_abc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,11 @@ def _ensure_distinct_path(self, other_path):
"""
Raise OSError(EINVAL) if the other path is within this path.
"""
# Note: there is no straightforward, foolproof algorithm to determine
# if one directory is within another. A particularly perverse example:
# consider a single network share mounted in one location via NFS, and
# in another location via CIFS. This method simply checks whether the
# other_path is lexically equal to, or within, this path.
Comment thread
picnixz marked this conversation as resolved.
Outdated
if self == other_path:
err = OSError(EINVAL, "Source and target are the same path")
elif self in other_path.parents:
Expand Down