Skip to content

gh-122575: Include sys.flags.gil as a sequence attribute #122576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
colesbury wants to merge 3 commits into from
Closed

gh-122575: Include sys.flags.gil as a sequence attribute #122576

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfaa04f
gh-122575: Include `sys.flags.gil` as a sequence attribute
colesbury Aug 1, 2024
7a41cfc
sys.flags.gil may be None or an int
colesbury Aug 1, 2024
dbf5189
Update Python/sysmodule.c
colesbury Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
sys.flags.gil may be None or an int
  • Loading branch information
@colesbury
colesbury committed Aug 1, 2024
commit 7a41cfc68035214762f637a56b30954ebc5f384c
9 changes: 7 additions & 2 deletions Lib/test/test_sys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,10 +805,15 @@ def test_sys_flags(self):
"hash_randomization", "isolated", "dev_mode", "utf8_mode",
"warn_default_encoding", "safe_path", "int_max_str_digits",
"gil")
attr_types = {
"dev_mode": bool,
"safe_path": bool,
"gil": (int, type(None)),
Copy link
Copy Markdown
Member

@picnixz picnixz Aug 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the None value mean that it's the free-threaded build or is it for something else?

}
for attr in attrs:
self.assertTrue(hasattr(sys.flags, attr), attr)
attr_type = bool if attr in ("dev_mode", "safe_path") else int
self.assertEqual(type(getattr(sys.flags, attr)), attr_type, attr)
expected_type = attr_types.get(attr, int)
self.assertIsInstance(getattr(sys.flags, attr), expected_type, attr)
self.assertTrue(repr(sys.flags))
self.assertEqual(len(sys.flags), len(attrs))

Expand Down