Skip to content

bpo-36245: If statements prefer brackets over quotes if it is a filepath that could contain a space.#12241

Merged
zooba merged 2 commits into
python:masterfrom
j3ska:fix-issue-36230
Mar 21, 2019
Merged

bpo-36245: If statements prefer brackets over quotes if it is a filepath that could contain a space.#12241
zooba merged 2 commits into
python:masterfrom
j3ska:fix-issue-36230

Conversation

@j3ska

@j3ska j3ska commented Mar 8, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Apologies in advance if this is pull isn't quite right. I live in perforce and feel extremely clumsy in git.

https://bugs.python.org/issue36245

@j3ska j3ska requested a review from a team as a code owner March 8, 2019 21:47
zooba
zooba approved these changes Mar 21, 2019
View reviewed changes

@zooba zooba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zooba zooba merged commit 7ee88bf into python:master Mar 21, 2019
@miss-islington

miss-islington commented Mar 21, 2019

Copy link
Copy Markdown
Contributor

Thanks @j3ska for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 21, 2019
@j3ska @miss-islington
bpo-36245: Avoid problems when building in a directory containing spa…
226fa3f 
…ces. (pythonGH-12241)

(cherry picked from commit 7ee88bf)

Co-authored-by: Jess <jess@gmail.com>
@bedevere-bot

bedevere-bot commented Mar 21, 2019

Copy link
Copy Markdown

GH-12484 is a backport of this pull request to the 3.7 branch.

@miss-islington

miss-islington commented Mar 21, 2019

Copy link
Copy Markdown
Contributor

Thanks @j3ska for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Mar 21, 2019

Copy link
Copy Markdown
Contributor

Sorry, @j3ska and @zooba, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7ee88bf3e59493137a775368165c5c5fe1ed7f46 2.7

miss-islington added a commit that referenced this pull request Mar 21, 2019
@miss-islington @j3ska
bpo-36245: Avoid problems when building in a directory containing spa…
b058a97 
…ces. (GH-12241)

(cherry picked from commit 7ee88bf)

Co-authored-by: Jess <jess@gmail.com>
zooba added a commit to zooba/cpython that referenced this pull request Mar 27, 2019
@zooba
bpo-36245: Avoid problems when building in a directory containing spa…
c995df8 
…ces. (pythonGH-12241)
@bedevere-bot

bedevere-bot commented Mar 27, 2019

Copy link
Copy Markdown

GH-12591 is a backport of this pull request to the 2.7 branch.

zooba added a commit that referenced this pull request Mar 27, 2019
@zooba
bpo-36245: Avoid problems when building in a directory containing spa…
bb89aa2 
…ces. (GH-12241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes

Assignees

@zooba zooba

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@j3ska @miss-islington @bedevere-bot @zooba @the-knights-who-say-ni