Skip to content

gh-122179: Fix hashlib.file_digest and non-blocking I/O #122183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 6 commits into from
Apr 21, 2025
+22 −1
Merged

gh-122179: Fix hashlib.file_digest and non-blocking I/O #122183

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b7a1e6e
Fix hashlib.file_digest and non-blocking I/O
srittau Jul 23, 2024
d571850
Remove trailing space
srittau Jul 23, 2024
5669cce
Add documentation around this behavior
srittau Aug 1, 2024
d4b385f
Merge branch 'main' into file-digest-readinto
srittau Feb 27, 2025
218fd35
Merge branch 'main' into file-digest-readinto
srittau Apr 14, 2025
612f7d4
Add versionchanged
srittau Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into file-digest-readinto
  • Loading branch information
@srittau
srittau committed Feb 27, 2025
commit d4b385fff22fa428e37b06f0b49f1af1b451fe2b
8 changes: 0 additions & 8 deletions Lib/test/test_hashlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1194,14 +1194,6 @@ def test_file_digest(self):
with self.assertRaises(ValueError):
hashlib.file_digest(None, "sha256")

with self.assertRaises(ValueError):
with open(os_helper.TESTFN, "r") as f:
hashlib.file_digest(f, "sha256")

with self.assertRaises(ValueError):
with open(os_helper.TESTFN, "wb") as f:
hashlib.file_digest(f, "sha256")

class NonBlocking:
def readinto(self, buf):
return None
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.