Skip to content

gh-121804: always show error location for SyntaxError's in new repl #121886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 7 commits into from
Aug 19, 2024
Merged

gh-121804: always show error location for SyntaxError's in new repl #121886

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f5f0d53
gh-121804: always show error location for SyntaxError's in new repl
skirpichev Jul 16, 2024
25dfe26
amend news
skirpichev Jul 17, 2024
f0e8d21
Merge branch 'master' into show-syntaxerr-location-121804
skirpichev Aug 18, 2024
a196862
Merge branch 'master' into show-syntaxerr-location-121804
skirpichev Aug 18, 2024
1aeabf2
+ reorder guard statements
skirpichev Aug 18, 2024
9b3ff96
Merge branch 'master' into show-syntaxerr-location-121804
skirpichev Aug 19, 2024
bb89ab1
address review: add guard and rewrote news entry
skirpichev Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
+ reorder guard statements
  • Loading branch information
@skirpichev
skirpichev committed Aug 18, 2024
commit 1aeabf2ce42d01fbf3c76daef8d794a18ea39149
2 changes: 1 addition & 1 deletion Lib/code.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def _showtraceback(self, typ, value, tb, source):
sys.last_traceback = tb
value = value.with_traceback(tb)
# Set the line of text that the exception refers to
if source and not value.text and typ is SyntaxError:
if source and typ is SyntaxError and not value.text:
value.text = source.splitlines()[value.lineno - 1]
Comment thread
skirpichev marked this conversation as resolved.
Outdated
sys.last_exc = sys.last_value = value
if sys.excepthook is sys.__excepthook__:
Expand Down