Skip to content

Integrate build_msi into main CI workflow #121778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 3 commits into from
Jul 24, 2024
+56 −40
Merged

Integrate build_msi into main CI workflow #121778

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
290c3be
🧪💅 Integrate `build_msi` into main CI workflow
webknjaz Jul 14, 2024
a6bbc82
Make the CI job name less fun
webknjaz Jul 23, 2024
a0a5372
Fix the MSI change detection step title
webknjaz Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make the CI job name less fun 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
  • Loading branch information
@webknjaz @hugovk
webknjaz and hugovk committed Jul 23, 2024
commit a6bbc82fe8215f5824b7dd51fd71cc1370e13ab8
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ jobs:

build_windows_msi:
name: >- # ${{ '' } is a hack to nest jobs under the same sidebar category
📦 Windows MSI${{ '' }}
Windows MSI${{ '' }}
Copy link
Copy Markdown
Member

@hugovk hugovk Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webknjaz Someone else has said "Tests / Windows MSI${{ '' }} (pull_request)" looks like a bug.

I think in some other thread you said we can adjust it somehow, is that possible?

Copy link
Copy Markdown
Member Author

@webknjaz webknjaz Aug 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugovk basically, there are two options:

  • split this into two matrices in the top-level workflow
  • move the interpolated part of the name into the reusable ones

I personally like the second option. Let me know if you or @ambv want something different.

Copy link
Copy Markdown
Member Author

@webknjaz webknjaz Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though, I think both might break grouping 🤔

Copy link
Copy Markdown
Member

@hugovk hugovk Aug 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, any other ideas? Someone else has asked about it because it looks weird.

Copy link
Copy Markdown
Member Author

@webknjaz webknjaz Aug 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be most impactful if GitHub fixed this in its own UI rather than having people resort to hacks. I'd be happy to drop the ${{ '' }} hack from other places.

Would it be less confusing is we switched Windows MSI${{ '' }} to ${{ 'Windows MSI' }}?

Copy link
Copy Markdown
Member

@hugovk hugovk Aug 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think that might be a bit better?

The recent query was actually about the fromJSON stuff, do you think we can do anything about that?

image

Copy link
Copy Markdown
Member Author

@webknjaz webknjaz Aug 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicating the matrix or moving the conditional inside the reusable workflow would improve this, I suppose.

Copy link
Copy Markdown
Member Author

@webknjaz webknjaz Aug 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done some thinking and realized that duplicating the matrices is the only way to make it look different while preserving the matrix grouping in the UI.

Copy link
Copy Markdown
Member

@ezio-melotti ezio-melotti Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I also thought it was a bug (e.g. a missing space before the $ that prevented its expansion) and ended up here. I noticed it in #136959.

Copy link
Copy Markdown
Member Author

@webknjaz webknjaz Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.. We should all go complain to GitHub so the hack would be redundant. Over the past few months, when I was bragging about a few other GHA ideas a couple of people saw this in those examples and immediately were like "I'm now going to be using this everywhere". I never really reported the bug to GitHub but probably should.

needs: check_source
if: fromJSON(needs.check_source.outputs.run-win-msi)
strategy:
Expand Down