Fixed an issue where building inside of a clone directory with spaces would result in not being able to build at all.#121384
Merged
Conversation
zooba
reviewed
Jul 5, 2024
Member
zooba
left a comment
There was a problem hiding this comment.
Agreed no issue required, but let's keep the change only to the places that need it.
AraHaan
commented
Jul 5, 2024
AraHaan
commented
Jul 5, 2024
would result in not being able to build at all. This is an issue as some people have github repositories with spaces in name and has cpython as a submodule so they can test with the latest and greatest main branch and the feature branches (3.13, 3.12, etc) Having regen.targets use the " msbuild escape sequence for all input and output file paths ensures that this issue never happens again as long as the paths are wrapped in quotes. Also it's not acceptable to have to move the submodule out of the folder with a space nor is it acceptable to rename the folder that has a space sometimes. Using Quotes is a more acceptable solution to this.
4d7b9f8 to
27e0f3e
Compare
AraHaan
commented
Jul 5, 2024
Member
|
Thanks for the fix, @AraHaan |
Member
|
Not sure why the bots aren't doing backports right now... maybe they're taking a (US) holiday. Edit: Pinged some people who probably know what's going on and/or what to do about it. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 5, 2024
) (cherry picked from commit 0e77540) Co-authored-by: AraHaan <seandhunt_7@yahoo.com>
|
Sorry, @AraHaan and @zooba, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 5, 2024
) (cherry picked from commit 0e77540) Co-authored-by: AraHaan <seandhunt_7@yahoo.com>
|
Sorry, @AraHaan and @zooba, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 5, 2024
) (cherry picked from commit 0e77540) Co-authored-by: AraHaan <seandhunt_7@yahoo.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 5, 2024
) (cherry picked from commit 0e77540) Co-authored-by: AraHaan <seandhunt_7@yahoo.com>
|
GH-121411 is a backport of this pull request to the 3.13 branch. |
zooba
pushed a commit
that referenced
this pull request
Jul 8, 2024
(cherry picked from commit 0e77540) Co-authored-by: AraHaan <seandhunt_7@yahoo.com>
Member
|
Doesn't actually impact 3.12 |
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I felt this is a trivial change and did not need an issue.
This is an issue as some people have github repositories with spaces in name and has cpython as a submodule so they can test with the latest and greatest main branch and the feature branches (3.13, 3.12, etc)
Having regen.targets use the " msbuild escape sequence for all input and output file paths ensures that this issue never happens again as long as the paths are wrapped in quotes. Also it's not acceptable to have to move the submodule out of the folder with a space nor is it acceptable to rename the folder that has a space sometimes. Using Quotes is a more acceptable solution to this.