Skip to content

[3.12] gh-121035: Further improve logging flow diagram with respect t… #121321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vsajip merged 1 commit into from
Jul 3, 2024
Merged

[3.12] gh-121035: Further improve logging flow diagram with respect t… #121321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[3.12] gh-121035: Further improve logging flow diagram with respect t… 
…o dark/light modes. (GH-121265)

(cherry picked from commit 0898354)

Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
  • Loading branch information
@vsajip
vsajip committed Jul 3, 2024
commit 6c74b2036ddb8d00f3bbd32b6c6a3036118961dd
6 changes: 4 additions & 2 deletions Doc/howto/logging.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,11 +402,13 @@ following diagram.
function updateBody(theme) {
let elem = document.body;

elem.classList.remove('dark-theme');
elem.classList.remove('light-theme');
if (theme === 'dark') {
elem.classList.add('dark-theme');
}
else {
elem.classList.remove('dark-theme');
else if (theme === 'light') {
elem.classList.add('light-theme');
}
}

Expand Down
10 changes: 10 additions & 0 deletions Doc/howto/logging_flow.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.