Skip to content

gh-121192: Add fast path to deepcopy() for empty list/tuple/dict/set #121193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lgeiger wants to merge 5 commits into from
Closed

gh-121192: Add fast path to deepcopy() for empty list/tuple/dict/set #121193

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f317c1b
Optimize deepcopy of empty containers
lgeiger Jun 30, 2024
943a10f
Remove special case for tuple and frozensets
lgeiger Jun 30, 2024
68c589f
Add NEWS entry
lgeiger Jun 30, 2024
ba7298c
Don't call len for checking for empty container
lgeiger Jul 1, 2024
d87901e
Revert optimization for nested empty containers
lgeiger Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't call len for checking for empty container
  • Loading branch information
@lgeiger
lgeiger committed Jul 1, 2024
commit ba7298c7ff9801ccac64a3d127b279de5b3524dc
4 changes: 2 additions & 2 deletions Lib/copy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ def deepcopy(x, memo=None, _nil=[]):
return x

if memo is None:
if cls in _builtin_iterables and len(x) == 0:
if cls in _builtin_iterables and not x:
Comment thread
lgeiger marked this conversation as resolved.
return cls()
d = id(x)
memo = {}
Expand All @@ -137,7 +137,7 @@ def deepcopy(x, memo=None, _nil=[]):
if y is not _nil:
return y

if cls in _builtin_iterables and len(x) == 0:
if cls in _builtin_iterables and not x:
Comment thread
lgeiger marked this conversation as resolved.
Outdated
y = cls()
elif copier := _deepcopy_dispatch.get(cls):
y = copier(x, memo)
Expand Down