Skip to content

gh-120804: remove is_active method from internal child watchers implementation in asyncio #121124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 1 commit into from
Jun 28, 2024
+0 −6
Merged

gh-120804: remove is_active method from internal child watchers implementation in asyncio #121124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
remove is_active methods
  • Loading branch information
@kumaraditya303
kumaraditya303 committed Jun 28, 2024
commit 9c0a0a2cd2cfd5c9ce0dd8768e483e2ab25ca081
6 changes: 0 additions & 6 deletions Lib/asyncio/unix_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,9 +867,6 @@ class _PidfdChildWatcher:
recent (5.3+) kernels.
"""

def is_active(self):
return True

def add_child_handler(self, pid, callback, *args):
loop = events.get_running_loop()
pidfd = os.pidfd_open(pid)
Expand Down Expand Up @@ -911,9 +908,6 @@ def __init__(self):
self._pid_counter = itertools.count(0)
self._threads = {}

def is_active(self):
return True

def __del__(self, _warn=warnings.warn):
threads = [thread for thread in list(self._threads.values())
if thread.is_alive()]
Expand Down