Skip to content

gh-120868: Fix breaking change in logging.config when using QueueHandler #120872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vsajip merged 6 commits into from
Jun 27, 2024
Merged

gh-120868: Fix breaking change in logging.config when using QueueHandler #120872

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0723f49
gh-120868: Fix regression in logging.config where multiprocessing.Man…
provinzkraut Jun 22, 2024
afcc79e
Add News fragment
provinzkraut Jun 22, 2024
08bc4d6
Update Misc/ACKS to make patchcheck happy
provinzkraut Jun 22, 2024
a828c0d
Merge branch 'python:main' into fix-gh-120868
provinzkraut Jun 22, 2024
ccc0060
Revert "Add News fragment"
provinzkraut Jun 23, 2024
6daf85e
Restructure as per review comment
provinzkraut Jun 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Restructure as per review comment
  • Loading branch information
@provinzkraut
provinzkraut committed Jun 23, 2024
commit 6daf85e18ed2844654bebdb08be881ed1f55314d
11 changes: 9 additions & 2 deletions Lib/logging/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,8 +804,15 @@ def configure_handler(self, config):
# if it's not an instance of BaseProxy, it also can't be
# an instance of Manager.Queue / Manager.JoinableQueue
if isinstance(qspec, BaseProxy):
proxy_queue = MM().Queue()
proxy_joinable_queue = MM().JoinableQueue()
# Sometimes manager or queue creation might fail
# (e.g. see issue gh-120868). In that case, any
# exception during the creation of these queues will
# propagate up to the caller and be wrapped in a
# `ValueError`, whose cause will indicate the details of
# the failure.
mm = MM()
proxy_queue = mm.Queue()
proxy_joinable_queue = mm.JoinableQueue()
if not isinstance(qspec, (type(proxy_queue), type(proxy_joinable_queue))):
raise TypeError('Invalid queue specifier %r' % qspec)
else:
Expand Down