Skip to content

gh-119182: Add PyUnicodeWriter_WriteUCS4() function #120849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 7 commits into from
Jun 24, 2024
Merged

gh-119182: Add PyUnicodeWriter_WriteUCS4() function #120849

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d6d0203
gh-119182: Add PyUnicodeWriter_WriteUCS4() function
vstinner Jun 20, 2024
4635f5f
Merge branch 'main' into writer_ucs4
vstinner Jun 24, 2024
aefcbf8
size must be positive
vstinner Jun 24, 2024
e18a47c
Use PyUnicodeWriter_WriteUCS4() on Solaris
vstinner Jun 24, 2024
056c42e
Fix typo
vstinner Jun 24, 2024
8c7691a
Update tests
vstinner Jun 24, 2024
76e66dd
Add more tests
vstinner Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
size must be positive
  • Loading branch information
@vstinner
vstinner committed Jun 24, 2024
commit aefcbf898adee901bf3990310a039c6618237f8c
3 changes: 1 addition & 2 deletions Doc/c-api/unicode.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1567,8 +1567,7 @@ object.

Writer the UCS4 string *str* into *writer*.

*size* is a number of UCS4 characters. If *size* is equal to ``-1``, get the
string length (search the NUL character).
*size* is a number of UCS4 characters.

On success, return ``0``.
On error, set an exception, leave the writer unchanged, and return ``-1``.
Expand Down
5 changes: 3 additions & 2 deletions Objects/unicodeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2298,8 +2298,9 @@ PyUnicodeWriter_WriteUCS4(PyUnicodeWriter *pub_writer,
_PyUnicodeWriter *writer = (_PyUnicodeWriter*)pub_writer;

if (size < 0) {
size = 0;
for (; str[size] != '\0'; size++);
PyErr_SetString(PyExc_TypeError,
"size must be positive");
return NULL;
}

if (size == 0) {
Expand Down