Use symbolic names for SEEK_SET, etc, instead of hardcoding them#12057
Merged
Conversation
The previous code hardcoded `SEEK_SET`, etc. While it's very unlikely that these values will change, it's best to use the definitions to avoid there being mismatches in behavior with the code in the future. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
Contributor
Author
|
@serhiy-storchaka: while it isn't directly tied to the issue discussed in https://bugs.python.org/issue36111, it is something that (when inspecting the code), I thought should be changed. I remember looking at this code in the past and thinking similar things, IIRC. |
Member
|
I am not sure this PR should be merged. Once I wrote much larger patch which replaced literal numbers with named constants In any case this change introduced a bug: missed |
Contributor
Author
|
@serhiy-storchaka: crap. I had fixed that before.. not sure why it wasn’t in the merge content :(.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code hardcoded
SEEK_SET, etc. While it's very unlikelythat these values will change, it's best to use the definitions to avoid
there being mismatches in behavior with the code in the future.
Signed-off-by: Enji Cooper yaneurabeya@gmail.com