Skip to content

GH-73991: Add follow_symlinks argument to pathlib.Path.copy() #120519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barneygale merged 4 commits into from
Jun 19, 2024
Merged

GH-73991: Add follow_symlinks argument to pathlib.Path.copy() #120519

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34a3365
GH-73991: Add *follow_symlinks* argument to `pathlib.Path.copy()`
barneygale Jun 14, 2024
38bf791
Test copying to existing symlink with follow_symlinks=False
barneygale Jun 19, 2024
0717792
Check for os.stat_result.st_file_attributes
barneygale Jun 19, 2024
de5a230
Add underscore prefix
barneygale Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test copying to existing symlink with follow_symlinks=False
  • Loading branch information
@barneygale
barneygale committed Jun 19, 2024
commit 38bf791c05ffefa5fee663ec4e910b3bc0592f16
13 changes: 13 additions & 0 deletions Lib/test/test_pathlib/test_pathlib_abc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1769,6 +1769,19 @@ def test_copy_to_existing_symlink(self):
self.assertFalse(real_target.is_symlink())
self.assertEqual(source.read_text(), real_target.read_text())

@needs_symlinks
def test_copy_to_existing_symlink_follow_symlinks_false(self):
base = self.cls(self.base)
source = base / 'dirB' / 'fileB'
target = base / 'linkA'
real_target = base / 'fileA'
source.copy(target, follow_symlinks=False)
self.assertTrue(target.exists())
self.assertTrue(target.is_symlink())
self.assertTrue(real_target.exists())
self.assertFalse(real_target.is_symlink())
self.assertEqual(source.read_text(), real_target.read_text())

def test_copy_empty(self):
base = self.cls(self.base)
source = base / 'empty'
Expand Down