Skip to content

gh-120389: Add PyLong_FromInt64() and PyLong_AsInt64() #120390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 12 commits into from
Aug 28, 2024
Merged

gh-120389: Add PyLong_FromInt64() and PyLong_AsInt64() #120390

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3e50341
gh-120389: Add PyLong_FromInt64() and PyLong_ToInt64()
vstinner Jun 12, 2024
7c7b976
Add uint32_t to Doc/conf.py
vstinner Jun 19, 2024
c239d18
Use PyLong_AsNativeBytes()
vstinner Jun 20, 2024
1186043
Group documentations
vstinner Jun 20, 2024
c2150c1
Replace "To" with "As"
vstinner Aug 27, 2024
050f415
Merge branch 'main' into stdint
vstinner Aug 27, 2024
830d250
Use Py_ASNATIVEBYTES_ALLOW_INDEX
vstinner Aug 27, 2024
42b9902
stable_abi: replace "To" with "As"
vstinner Aug 27, 2024
0199a80
Address Bénédikt's review
vstinner Aug 27, 2024
71748a7
Remove check_long_asunsignedint() in tests
vstinner Aug 28, 2024
dd2194e
Update Doc/c-api/long.rst
vstinner Aug 28, 2024
7070514
Update Doc/c-api/long.rst
vstinner Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use Py_ASNATIVEBYTES_ALLOW_INDEX
  • Loading branch information
@vstinner
vstinner committed Aug 27, 2024
commit 830d250818ea4a7cc2d337d75b46891c7a484af6
8 changes: 4 additions & 4 deletions Lib/test/test_capi/test_long.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,26 +659,26 @@ def test_long_asint32(self):
# Test PyLong_AsInt32() and PyLong_FromInt32()
to_int32 = _testlimitedcapi.pylong_asint32
from _testcapi import INT32_MIN, INT32_MAX
self.check_long_asint(to_int32, INT32_MIN, INT32_MAX, use_index=False)
self.check_long_asint(to_int32, INT32_MIN, INT32_MAX)

def test_long_asint64(self):
# Test PyLong_AsInt64() and PyLong_FromInt64()
as_int64 = _testlimitedcapi.pylong_asint64
from _testcapi import INT64_MIN, INT64_MAX
self.check_long_asint(as_int64, INT64_MIN, INT64_MAX, use_index=False)
self.check_long_asint(as_int64, INT64_MIN, INT64_MAX)

def test_long_asuint32(self):
# Test PyLong_AsUInt32() and PyLong_FromUInt32()
as_uint32 = _testlimitedcapi.pylong_asuint32
from _testcapi import UINT32_MAX
self.check_long_asunsignedint(as_uint32, UINT32_MAX,
self.check_long_asunsignedint(as_uint32, UINT32_MAX, use_index=True,
negative_value_error=True)

def test_long_asuint64(self):
# Test PyLong_AsUInt64() and PyLong_FromUInt64()
as_uint64 = _testlimitedcapi.pylong_asuint64
from _testcapi import UINT64_MAX
self.check_long_asunsignedint(as_uint64, UINT64_MAX,
self.check_long_asunsignedint(as_uint64, UINT64_MAX, use_index=True,
negative_value_error=True)

if __name__ == "__main__":
Expand Down
6 changes: 4 additions & 2 deletions Objects/longobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6743,7 +6743,8 @@ PyObject* PyLong_FromUInt64(uint64_t value)

#define LONG_TO_INT(obj, value, type_name) \
do { \
int flags = Py_ASNATIVEBYTES_NATIVE_ENDIAN; \
int flags = (Py_ASNATIVEBYTES_NATIVE_ENDIAN \
| Py_ASNATIVEBYTES_ALLOW_INDEX); \
Py_ssize_t bytes = PyLong_AsNativeBytes(obj, value, sizeof(*value), flags); \
if (bytes < 0) { \
return -1; \
Expand All @@ -6770,7 +6771,8 @@ int PyLong_AsInt64(PyObject *obj, int64_t *value)
do { \
int flags = (Py_ASNATIVEBYTES_NATIVE_ENDIAN \
| Py_ASNATIVEBYTES_UNSIGNED_BUFFER \
| Py_ASNATIVEBYTES_REJECT_NEGATIVE); \
| Py_ASNATIVEBYTES_REJECT_NEGATIVE \
| Py_ASNATIVEBYTES_ALLOW_INDEX); \
Py_ssize_t bytes = PyLong_AsNativeBytes(obj, value, sizeof(*value), flags); \
Comment thread
vstinner marked this conversation as resolved.
if (bytes < 0) { \
return -1; \
Expand Down