Skip to content

gh-120010: fix invalid (nan+nanj) results in _Py_c_prod() #120287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 9 commits into from
Dec 6, 2024
Merged

gh-120010: fix invalid (nan+nanj) results in _Py_c_prod() #120287

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
399e3e3
gh-120010: fix invalid (nan+nanj) results in _Py_c_prod()
skirpichev Jun 4, 2024
324c602
address review: declarations
skirpichev Jun 10, 2024
fcafe33
Merge branch 'main' into cc-in-py_c_prod-120010
skirpichev Sep 27, 2024
5509a2d
address review: use subTest
skirpichev Sep 27, 2024
0e98116
Update Misc/NEWS.d/next/Core and Builtins/2024-06-04-08-26-25.gh-issu…
skirpichev Sep 27, 2024
338176d
+ fix typo
skirpichev Sep 27, 2024
83456ef
Merge branch 'main' into cc-in-py_c_prod-120010
skirpichev Nov 27, 2024
219c0cb
+ rename
skirpichev Nov 27, 2024
e368f23
Update Objects/complexobject.c
skirpichev Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address review: use subTest
  • Loading branch information
@skirpichev
skirpichev committed Sep 27, 2024
commit 5509a2d209206b9481794015f6a9109fbb70dee0
51 changes: 15 additions & 36 deletions Lib/test/test_complex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,42 +242,21 @@ def test_mul(self):
self.assertRaises(TypeError, operator.mul, 1j, None)
self.assertRaises(TypeError, operator.mul, None, 1j)

self.assertComplexesAreIdentical((1e300+1j) * complex(INF, INF),
complex(NAN, INF))
self.assertComplexesAreIdentical(complex(INF, INF) * (1e300+1j),
complex(NAN, INF))
self.assertComplexesAreIdentical((1e300+1j) * complex(NAN, INF),
complex(-INF, INF))
self.assertComplexesAreIdentical(complex(NAN, INF) * (1e300+1j),
complex(-INF, INF))
self.assertComplexesAreIdentical((1e300+1j) * complex(INF, NAN),
complex(INF, INF))
self.assertComplexesAreIdentical(complex(INF, NAN) * (1e300+1j),
complex(INF, INF))
self.assertComplexesAreIdentical(complex(INF, 1) * complex(NAN, INF),
complex(NAN, INF))
self.assertComplexesAreIdentical(complex(INF, 1) * complex(INF, NAN),
complex(INF, NAN))
self.assertComplexesAreIdentical(complex(NAN, INF) * complex(INF, 1),
complex(NAN, INF))
self.assertComplexesAreIdentical(complex(INF, NAN) * complex(INF, 1),
complex(INF, NAN))
self.assertComplexesAreIdentical(complex(NAN, 1) * complex(1, INF),
complex(-INF, NAN))
self.assertComplexesAreIdentical(complex(1, NAN) * complex(1, INF),
complex(NAN, INF))

self.assertComplexesAreIdentical(complex(1e200, NAN) * complex(1e200, NAN),
complex(INF, NAN))
self.assertComplexesAreIdentical(complex(1e200, NAN) * complex(NAN, 1e200),
complex(NAN, INF))
self.assertComplexesAreIdentical(complex(NAN, 1e200) * complex(1e200, NAN),
complex(NAN, INF))
self.assertComplexesAreIdentical(complex(NAN, 1e200) * complex(NAN, 1e200),
complex(-INF, NAN))

self.assertComplexesAreIdentical(complex(NAN, NAN) * complex(NAN, NAN),
complex(NAN, NAN))
for z, w, r in [(1e300+1j, complex(INF, INF), complex(NAN, INF)),
(1e300+1j, complex(NAN, INF), complex(-INF, INF)),
(1e300+1j, complex(INF, NAN), complex(INF, INF)),
(complex(INF, 1), complex(NAN, INF), complex(NAN, INF)),
(complex(INF, 1), complex(INF, NAN), complex(INF, NAN)),
(complex(NAN, 1), complex(1, INF), complex(-INF, NAN)),
(complex(1, NAN), complex(1, INF), complex(NAN, INF)),
(complex(1e200, NAN), complex(1e200, NAN), complex(INF, NAN)),
(complex(1e200, NAN), complex(NAN, 1e200), complex(NAN, INF)),
(complex(NAN, 1e200), complex(1e200, NAN), complex(NAN, INF)),
(complex(NAN, 1e200), complex(NAN, 1e200), complex(-INF, NAN)),
(complex(NAN, NAN), complex(NAN, NAN), complex(NAN, NAN))]:
with self.subTest(z=z, w=w, r=r):
self.assertComplexesAreIdentical(z * w, s)
self.assertComplexesAreIdentical(w * z, s)

def test_mod(self):
# % is no longer supported on complex numbers
Expand Down