gh-120048: Make test_imaplib faster#120050
Merged
Merged
Conversation
The `test_imaplib` was taking 40+ minutes in the refleak build bots because we were using LOOPBACK_TIMEOUT for tests cases that expect to timeout. LOOPBACK_TIMEOUT scales with the global timeout. We should use a fixed, very small timeout for cases that we expect to timeout.
Comment on lines
+477
to
+478
| client = self.imap_class("localhost", addr, timeout=FAST_TIMEOUT) | ||
| self.assertEqual(client.sock.timeout, FAST_TIMEOUT) |
Member
There was a problem hiding this comment.
Should not an explicit timeout be different from SimpleIMAPHandler.timeout? Otherwise we cannot know how the value of client.sock.timeout was set.
You perhaps can use expect_timeout() as a context manager instead of a decorator.
Contributor
Author
There was a problem hiding this comment.
I misunderstood the problem with this test -- these connections should not time out. The problem was that the call self._setup(SimpleIMAPHandler) created a client and the remainder of the test did not run until that client timedout.
We should use self._setup(SimpleIMAPHandler, connect=False)
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Contributor
Author
|
!buildbot AMD64 Ubuntu NoGIL Refleaks |
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit fcce846 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 4, 2024
The `test_imaplib` was taking 40+ minutes in the refleak build bots because the tests waiting on a client `self._setup()` was creating a client that prevented progress until its connection timed out, which scaled with the global timeout. We should set `connect=False` for the tests that don't want `_setup()` to create a client. (cherry picked from commit 710cbea) Co-authored-by: Sam Gross <colesbury@gmail.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-120069 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 4, 2024
The `test_imaplib` was taking 40+ minutes in the refleak build bots because the tests waiting on a client `self._setup()` was creating a client that prevented progress until its connection timed out, which scaled with the global timeout. We should set `connect=False` for the tests that don't want `_setup()` to create a client. (cherry picked from commit 710cbea) Co-authored-by: Sam Gross <colesbury@gmail.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-120070 is a backport of this pull request to the 3.12 branch. |
colesbury
added a commit
that referenced
this pull request
Jun 4, 2024
The `test_imaplib` was taking 40+ minutes in the refleak build bots because the tests waiting on a client `self._setup()` was creating a client that prevented progress until its connection timed out, which scaled with the global timeout. We should set `connect=False` for the tests that don't want `_setup()` to create a client. (cherry picked from commit 710cbea) Co-authored-by: Sam Gross <colesbury@gmail.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
colesbury
added a commit
that referenced
this pull request
Jun 4, 2024
The `test_imaplib` was taking 40+ minutes in the refleak build bots because the tests waiting on a client `self._setup()` was creating a client that prevented progress until its connection timed out, which scaled with the global timeout. We should set `connect=False` for the tests that don't want `_setup()` to create a client. (cherry picked from commit 710cbea) Co-authored-by: Sam Gross <colesbury@gmail.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
barneygale
pushed a commit
to barneygale/cpython
that referenced
this pull request
Jun 5, 2024
The `test_imaplib` was taking 40+ minutes in the refleak build bots because the tests waiting on a client `self._setup()` was creating a client that prevented progress until its connection timed out, which scaled with the global timeout. We should set `connect=False` for the tests that don't want `_setup()` to create a client. Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
The `test_imaplib` was taking 40+ minutes in the refleak build bots because the tests waiting on a client `self._setup()` was creating a client that prevented progress until its connection timed out, which scaled with the global timeout. We should set `connect=False` for the tests that don't want `_setup()` to create a client. Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
The `test_imaplib` was taking 40+ minutes in the refleak build bots because the tests waiting on a client `self._setup()` was creating a client that prevented progress until its connection timed out, which scaled with the global timeout. We should set `connect=False` for the tests that don't want `_setup()` to create a client. Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test_imaplibwas taking 40+ minutes in the refleak build bots because the tests waiting on a clientself._setup()was creating a client that prevented progress until its connection timed out, which scaled with the global timeout.We should set
connect=Falsefor the tests that don't want_setup()to create a client.test_imaplibtakes 40+ minutes in refleaks builds #120048