Skip to content

gh-119946: Allow Enum to work with ABC mixin#119947

Open
ygale wants to merge 2 commits into
python:mainfrom
ygale:fix-issue-119946-enum-with-abc
Open

gh-119946: Allow Enum to work with ABC mixin#119947
ygale wants to merge 2 commits into
python:mainfrom
ygale:fix-issue-119946-enum-with-abc

Conversation

@ygale
Copy link
Copy Markdown

@ygale ygale commented Jun 2, 2024 •
edited by bedevere-app Bot
Loading

@ygale ygale requested a review from ethanfurman as a code owner June 2, 2024 15:40
@ghost
Copy link
Copy Markdown

ghost commented Jun 2, 2024 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 2, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app Bot mentioned this pull request Jun 2, 2024
Open
@ygale ygale force-pushed the fix-issue-119946-enum-with-abc branch from 4d0d1d8 to 2563fa2 Compare June 2, 2024 15:45
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 2, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@ygale ygale force-pushed the fix-issue-119946-enum-with-abc branch 2 times, most recently from 8f255ce to a141a73 Compare June 2, 2024 16:31
@nineteendo
Copy link
Copy Markdown
Contributor

nineteendo commented Jun 2, 2024

Could you avoid force pushing please?

In order to keep the commit history intact, please avoid squashing or amending history and then force-pushing to the PR. Reviewers often want to look at individual commits.

nineteendo
nineteendo reviewed Jun 2, 2024
View reviewed changes
Comment thread Lib/test/test_enum.py
@ygale ygale force-pushed the fix-issue-119946-enum-with-abc branch from a141a73 to 8487a73 Compare June 2, 2024 17:17
nineteendo
nineteendo reviewed Jun 2, 2024
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2024-06-02-19-26-01.gh-issue-119946.g8wtLh.rst Outdated
@ygale @nineteendo
Update Misc/NEWS.d/next/Library/2024-06-02-19-26-01.gh-issue-119946.g…
bc65a4b 
…8wtLh.rst

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
ethanfurman
ethanfurman requested changes Jun 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ethanfurman ethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test where a new enum class is created without the color method to ensure that enum creation fails.

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 3, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman ethanfurman requested changes

+1 more reviewer

@nineteendo nineteendo nineteendo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting changes stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ygale @nineteendo @ethanfurman