Skip to content

gh-119775: Remove ability to create immutable types with mutable bases #119776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobolevn merged 4 commits into from
Jun 2, 2024
Merged

gh-119775: Remove ability to create immutable types with mutable bases #119776

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
121bb1b
gh-119775: Remove ability to create immutable types with mutable bases
sobolevn May 30, 2024
d03ae98
Address review
sobolevn Jun 1, 2024
93c06df
Remove method
sobolevn Jun 1, 2024
7dd8471
Merge branch 'main' into issue-119775
sobolevn Jun 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove method
  • Loading branch information
@sobolevn
sobolevn committed Jun 1, 2024
commit 93c06dfcf67bb1d160683f1c20c50af74b412a93
4 changes: 1 addition & 3 deletions Lib/test/test_capi/test_misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,9 +778,7 @@ def test_pytype_fromspec_with_repeated_slots(self):
_testcapi.create_type_from_repeated_slots(variant)

def test_immutable_type_with_mutable_base(self):
class MutableBase:
def meth(self):
return 'original'
class MutableBase: ...

with self.assertRaisesRegex(TypeError, 'Creating immutable type'):
_testcapi.make_immutable_type_with_base(MutableBase)
Expand Down