Skip to content

gh-109218: Refactor tests for the complex() constructor #119635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 9 commits into from
May 30, 2024
Merged

gh-109218: Refactor tests for the complex() constructor #119635

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c35779b
gh-109218: Refactor tests for the complex() constructor
serhiy-storchaka May 27, 2024
607e2d5
Merge branch 'main' into complex-constructor-tests
serhiy-storchaka May 28, 2024
e8b6ba9
Add more tests.
serhiy-storchaka May 28, 2024
3c93ce2
Update Lib/test/test_complex.py
serhiy-storchaka May 28, 2024
3cb4b62
Rename some classes.
serhiy-storchaka May 29, 2024
dbbd5ad
Remove an outdated comment.
serhiy-storchaka May 29, 2024
bdbc301
Merge branch 'main' into complex-constructor-tests
serhiy-storchaka May 29, 2024
54fbfde
Merge branch 'main' into complex-constructor-tests
serhiy-storchaka May 30, 2024
8211f2d
Merge branch 'main' into complex-constructor-tests
serhiy-storchaka May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename some classes.
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed May 29, 2024
commit 3cb4b62693dba6581c229fb6bd1fb49539b4bd16
66 changes: 33 additions & 33 deletions Lib/test/test_complex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@
(1, 0+0j),
)

class MockIndex:
class WithIndex:
def __init__(self, value):
self.value = value
def __index__(self):
return self.value

class MockFloat:
class WithFloat:
def __init__(self, value):
self.value = value
def __float__(self):
Expand All @@ -36,7 +36,7 @@ def __float__(self):
class ComplexSubclass(complex):
pass

class MockComplex:
class WithComplex:
def __init__(self, value):
self.value = value
def __complex__(self):
Expand Down Expand Up @@ -372,7 +372,7 @@ def check(z, x, y):
check(complex(4.25+0j), 4.25, 0.0)
check(complex(4.25+0.5j), 4.25, 0.5)
check(complex(ComplexSubclass(4.25+0.5j)), 4.25, 0.5)
check(complex(MockComplex(4.25+0.5j)), 4.25, 0.5)
check(complex(WithComplex(4.25+0.5j)), 4.25, 0.5)

check(complex(1, 10), 1.0, 10.0)
check(complex(1, 10.0), 1.0, 10.0)
Expand All @@ -384,14 +384,14 @@ def check(z, x, y):

check(complex(4.25+0j, 0), 4.25, 0.0)
check(complex(ComplexSubclass(4.25+0j), 0), 4.25, 0.0)
check(complex(MockComplex(4.25+0j), 0), 4.25, 0.0)
check(complex(WithComplex(4.25+0j), 0), 4.25, 0.0)
check(complex(4.25j, 0), 0.0, 4.25)
check(complex(0j, 4.25), 0.0, 4.25)
check(complex(0, 4.25+0j), 0.0, 4.25)
check(complex(0, ComplexSubclass(4.25+0j)), 0.0, 4.25)
with self.assertRaisesRegex(TypeError,
"second argument must be a number, not 'MockComplex'"):
complex(0, MockComplex(4.25+0j))
"second argument must be a number, not 'WithComplex'"):
complex(0, WithComplex(4.25+0j))
check(complex(0.0, 4.25j), -4.25, 0.0)
check(complex(4.25+0j, 0j), 4.25, 0.0)
check(complex(4.25j, 0j), 0.0, 4.25)
Expand Down Expand Up @@ -439,13 +439,13 @@ def check(z, x, y):
"second arg can't be a string",
complex, 0, '1')

self.assertRaises(TypeError, complex, MockComplex(1.5))
self.assertRaises(TypeError, complex, MockComplex(1))
self.assertRaises(TypeError, complex, MockComplex(None))
self.assertRaises(TypeError, complex, MockComplex(4.25+0j), object())
self.assertRaises(TypeError, complex, MockComplex(1.5), object())
self.assertRaises(TypeError, complex, MockComplex(1), object())
self.assertRaises(TypeError, complex, MockComplex(None), object())
self.assertRaises(TypeError, complex, WithComplex(1.5))
self.assertRaises(TypeError, complex, WithComplex(1))
self.assertRaises(TypeError, complex, WithComplex(None))
self.assertRaises(TypeError, complex, WithComplex(4.25+0j), object())
self.assertRaises(TypeError, complex, WithComplex(1.5), object())
self.assertRaises(TypeError, complex, WithComplex(1), object())
self.assertRaises(TypeError, complex, WithComplex(None), object())

class EvilExc(Exception):
pass
Expand All @@ -456,25 +456,25 @@ def __complex__(self):

self.assertRaises(EvilExc, complex, evilcomplex())

check(complex(MockFloat(4.25)), 4.25, 0.0)
check(complex(MockFloat(4.25), 1.5), 4.25, 1.5)
check(complex(1.5, MockFloat(4.25)), 1.5, 4.25)
self.assertRaises(TypeError, complex, MockFloat(42))
self.assertRaises(TypeError, complex, MockFloat(42), 1.5)
self.assertRaises(TypeError, complex, 1.5, MockFloat(42))
self.assertRaises(TypeError, complex, MockFloat(None))
self.assertRaises(TypeError, complex, MockFloat(None), 1.5)
self.assertRaises(TypeError, complex, 1.5, MockFloat(None))

check(complex(MockIndex(42)), 42.0, 0.0)
check(complex(MockIndex(42), 1.5), 42.0, 1.5)
check(complex(1.5, MockIndex(42)), 1.5, 42.0)
self.assertRaises(OverflowError, complex, MockIndex(2**2000))
self.assertRaises(OverflowError, complex, MockIndex(2**2000), 1.5)
self.assertRaises(OverflowError, complex, 1.5, MockIndex(2**2000))
self.assertRaises(TypeError, complex, MockIndex(None))
self.assertRaises(TypeError, complex, MockIndex(None), 1.5)
self.assertRaises(TypeError, complex, 1.5, MockIndex(None))
check(complex(WithFloat(4.25)), 4.25, 0.0)
check(complex(WithFloat(4.25), 1.5), 4.25, 1.5)
check(complex(1.5, WithFloat(4.25)), 1.5, 4.25)
self.assertRaises(TypeError, complex, WithFloat(42))
self.assertRaises(TypeError, complex, WithFloat(42), 1.5)
self.assertRaises(TypeError, complex, 1.5, WithFloat(42))
self.assertRaises(TypeError, complex, WithFloat(None))
self.assertRaises(TypeError, complex, WithFloat(None), 1.5)
self.assertRaises(TypeError, complex, 1.5, WithFloat(None))

check(complex(WithIndex(42)), 42.0, 0.0)
check(complex(WithIndex(42), 1.5), 42.0, 1.5)
check(complex(1.5, WithIndex(42)), 1.5, 42.0)
self.assertRaises(OverflowError, complex, WithIndex(2**2000))
self.assertRaises(OverflowError, complex, WithIndex(2**2000), 1.5)
self.assertRaises(OverflowError, complex, 1.5, WithIndex(2**2000))
self.assertRaises(TypeError, complex, WithIndex(None))
self.assertRaises(TypeError, complex, WithIndex(None), 1.5)
self.assertRaises(TypeError, complex, 1.5, WithIndex(None))

class MyInt:
def __int__(self):
Expand Down