Skip to content

gh-119584: Fix test_import Failed Assertion #119623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 5 commits into from
May 27, 2024
+8 −2
Merged

gh-119584: Fix test_import Failed Assertion #119623

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a9ecfce
Clear m_index when clearing a singlephase extension.
ericsnowcurrently May 27, 2024
b01ac6e
Add a note about the check-state-first modules.
ericsnowcurrently May 27, 2024
6054a7d
Clear the check-state-first modules after loading them.
ericsnowcurrently May 27, 2024
7a23841
Fix _modules_by_index_check().
ericsnowcurrently May 27, 2024
3699d15
Move a line up.
ericsnowcurrently May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clear the check-state-first modules after loading them.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed May 27, 2024
commit 6054a7d8ec0de89c1ea65e34c98c099502e38673
3 changes: 3 additions & 0 deletions Lib/test/test_import/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2887,12 +2887,15 @@ def test_with_reinit_reloaded(self):

self.assertIs(reloaded.snapshot.cached, reloaded.module)

@unittest.skipIf(_testinternalcapi is None, "requires _testinternalcapi")
def test_check_state_first(self):
for variant in ['', '_with_reinit', '_with_state']:
name = f'{self.NAME}{variant}_check_cache_first'
with self.subTest(name):
mod = self._load_dynamic(name, self.ORIGIN)
self.assertEqual(mod.__name__, name)
sys.modules.pop(name, None)
_testinternalcapi.clear_extension(name, self.ORIGIN)

# Currently, for every single-phrase init module loaded
# in multiple interpreters, those interpreters share a
Expand Down