Skip to content

gh-118908: Limit exposed globals from internal imports and definitions on new REPL startup #119547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 19 commits into from
Jun 11, 2024
Merged

gh-118908: Limit exposed globals from internal imports and definitions on new REPL startup #119547

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
083f0a9
Limit exposed globals in new REPL
eugenetriguba May 25, 2024
bf17576
add blurb
eugenetriguba May 25, 2024
891477b
Merge branch 'main' into gh-118908
eugenetriguba May 25, 2024
2fabf57
tweak test
eugenetriguba May 25, 2024
d5d2321
fix type hint
eugenetriguba May 25, 2024
21a16f8
Add is_using_pyrepl
eugenetriguba May 26, 2024
5c5c496
Merge remote-tracking branch 'upstream/main' into gh-118908
pablogsal Jun 11, 2024
a9c0854
Simplify implementation
pablogsal Jun 11, 2024
d8760e8
Fix mypy
pablogsal Jun 11, 2024
bc49d05
Fix mypy
pablogsal Jun 11, 2024
adb074a
Fix windows
pablogsal Jun 11, 2024
d9a1085
Merge remote-tracking branch 'upstream/main' into gh-118908
pablogsal Jun 11, 2024
cdbc556
Fix generated files
pablogsal Jun 11, 2024
eaa6bc8
Fix generated files
pablogsal Jun 11, 2024
782b231
removed old file
pablogsal Jun 11, 2024
097f21e
Restore old file
pablogsal Jun 11, 2024
549a8d2
update news entry
pablogsal Jun 11, 2024
c95c035
fixup! update news entry
pablogsal Jun 11, 2024
688129b
Update Lib/test/test_pyrepl/test_pyrepl.py
lysnikolaou Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix mypy
  • Loading branch information
@pablogsal
pablogsal committed Jun 11, 2024
commit d8760e87f69b34c36dbbbddd824d53c3c58ea208
8 changes: 7 additions & 1 deletion Lib/_pyrepl/simple_interact.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@
from .console import InteractiveColoredConsole
from .readline import _get_reader, multiline_input

TYPE_CHECKING = False

if TYPE_CHECKING:
from typing import Any


_error: tuple[type[Exception], ...] | type[Exception]
try:
from .unix_console import _error
Expand Down Expand Up @@ -74,7 +80,7 @@ def _clear_screen():
"clear": _clear_screen,
}

DEFAULT_NAMESPACE = {
DEFAULT_NAMESPACE: dict[str, Any] = {
'__name__': '__main__',
'__doc__': None,
'__package__': None,
Expand Down
4 changes: 4 additions & 0 deletions Lib/test/test_pyrepl/test_pyrepl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,6 +844,10 @@ def test_exposed_globals_in_repl(self):
'["__annotations__", "__builtins__", "__doc__", "__loader__", '
'"__name__", "__package__", "__spec__"]'
)

with patch('_pyrepl.simple_interact.


output, exit_code = self.run_repl(["sorted(dir())", "exit"])
self.assertEqual(exit_code, 0)
output = output.replace("\'", '"')
Comment thread
lysnikolaou marked this conversation as resolved.
Outdated
Expand Down