Skip to content

gh-119260: Clarify is_dataclass Behavior for Subclasses in Documentation and Tests#119480

Merged
carljm merged 4 commits into
python:mainfrom
adiaholic:fix-issue-119260
May 29, 2024
Merged

gh-119260: Clarify is_dataclass Behavior for Subclasses in Documentation and Tests#119480
carljm merged 4 commits into
python:mainfrom
adiaholic:fix-issue-119260

Conversation

@adiaholic
Copy link
Copy Markdown
Contributor

@adiaholic adiaholic commented May 23, 2024 •
edited by github-actions Bot
Loading

@adiaholic adiaholic requested a review from ericvsmith as a code owner May 23, 2024 22:03
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 23, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app Bot mentioned this pull request May 23, 2024
Closed
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 23, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

carljm
carljm requested changes May 28, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Looks close, just a few suggested changes.

Comment thread Doc/library/dataclasses.rst Outdated
Comment thread Lib/test/test_dataclasses/__init__.py Outdated
Comment thread Lib/test/test_dataclasses/__init__.py Outdated
Comment thread Lib/test/test_dataclasses/__init__.py Outdated
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 28, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@adiaholic adiaholic closed this May 28, 2024
@adiaholic adiaholic reopened this May 28, 2024
@adiaholic
Copy link
Copy Markdown
Contributor Author

adiaholic commented May 28, 2024

Hi @carljm, I have made the requested changes; please review again.

Let me know if there is anything more that needs to be done.

Thanks !

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 28, 2024

Thanks for making the requested changes!

@carljm: please review the changes made to this pull request.

@bedevere-app bedevere-app Bot requested a review from carljm May 28, 2024 20:32
carljm
carljm reviewed May 28, 2024
View reviewed changes
Comment thread Lib/test/test_dataclasses/__init__.py Outdated
Comment thread Lib/test/test_dataclasses/__init__.py Outdated
carljm
carljm reviewed May 28, 2024
View reviewed changes
Comment thread Doc/library/dataclasses.rst Outdated
@carljm carljm enabled auto-merge (squash) May 28, 2024 21:35
@adiaholic
Copy link
Copy Markdown
Contributor Author

adiaholic commented May 29, 2024

Hi @carljm,
Tests / All required checks pass (pull_request) is failing because build_ubuntu_free_threading job was cancelled.

Could you please take a look and guide me if there is anything that can be done on my part ?

@carljm
Copy link
Copy Markdown
Member

carljm commented May 29, 2024

Don't know, merged in main to just trigger a new CI run.

@carljm carljm merged commit bf4ff3a into python:main May 29, 2024
@carljm carljm added the needs backport to 3.13 bugs and security fixes label May 30, 2024
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented May 30, 2024

Thanks @adiaholic for the PR, and @carljm for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2024
@adiaholic @carljm @miss-islington
pythongh-119260: Clarify is_dataclass Behavior for Subclasses in Docu…
5d04f0b 
…mentation and Tests (pythonGH-119480)

(cherry picked from commit bf4ff3a)

Co-authored-by: Aditya Borikar <adityaborikar2@gmail.com>
Co-authored-by: Carl Meyer <carl@oddbird.net>
@carljm carljm added the needs backport to 3.12 only security fixes label May 30, 2024
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 30, 2024

GH-119760 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 30, 2024
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented May 30, 2024

Thanks @adiaholic for the PR, and @carljm for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2024
@adiaholic @carljm @miss-islington
pythongh-119260: Clarify is_dataclass Behavior for Subclasses in Docu…
1ba2927 
…mentation and Tests (pythonGH-119480)

(cherry picked from commit bf4ff3a)

Co-authored-by: Aditya Borikar <adityaborikar2@gmail.com>
Co-authored-by: Carl Meyer <carl@oddbird.net>
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 30, 2024

GH-119761 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 30, 2024
carljm added a commit that referenced this pull request May 30, 2024
@miss-islington @adiaholic @carljm
[3.13] gh-119260: Clarify is_dataclass Behavior for Subclasses in Doc…
06c62d6 
…umentation and Tests (GH-119480) (#119760)

gh-119260: Clarify is_dataclass Behavior for Subclasses in Documentation and Tests (GH-119480)
(cherry picked from commit bf4ff3a)

Co-authored-by: Aditya Borikar <adityaborikar2@gmail.com>
Co-authored-by: Carl Meyer <carl@oddbird.net>
carljm added a commit that referenced this pull request May 30, 2024
@miss-islington @adiaholic @carljm
[3.12] gh-119260: Clarify is_dataclass Behavior for Subclasses in Doc…
681d7da 
…umentation and Tests (GH-119480) (#119761)

gh-119260: Clarify is_dataclass Behavior for Subclasses in Documentation and Tests (GH-119480)
(cherry picked from commit bf4ff3a)

Co-authored-by: Aditya Borikar <adityaborikar2@gmail.com>
Co-authored-by: Carl Meyer <carl@oddbird.net>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@adiaholic @carljm @noahbkim
pythongh-119260: Clarify is_dataclass Behavior for Subclasses in Docu…
ba2b375 
…mentation and Tests (python#119480)

Co-authored-by: Carl Meyer <carl@oddbird.net>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@adiaholic @carljm @estyxx
pythongh-119260: Clarify is_dataclass Behavior for Subclasses in Docu…
86cceaa 
…mentation and Tests (python#119480)

Co-authored-by: Carl Meyer <carl@oddbird.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adiaholic @carljm