Skip to content

[3.13] gh-117657: Fix missing atomic in dict_resize (GH-119312) #119417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DinoV merged 1 commit into from
May 22, 2024
Merged

[3.13] gh-117657: Fix missing atomic in dict_resize (GH-119312) #119417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-117657: Fix missing atomic in dict_resize (GH-119312) 
Fix missing atomic in dict_resize
(cherry picked from commit 2b3fb76)

Co-authored-by: Dino Viehland <dinoviehland@meta.com>
  • Loading branch information
@DinoV @miss-islington
DinoV authored and miss-islington committed May 22, 2024
commit 95b016a4d1b3270f1eb316efa1e294f79011415c
2 changes: 1 addition & 1 deletion Objects/dictobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2003,7 +2003,7 @@ dictresize(PyInterpreterState *interp, PyDictObject *mp,
if (oldvalues->embedded) {
assert(oldvalues->embedded == 1);
assert(oldvalues->valid == 1);
oldvalues->valid = 0;
FT_ATOMIC_STORE_UINT8(oldvalues->valid, 0);
}
else {
free_values(oldvalues, IS_DICT_SHARED(mp));
Expand Down