Skip to content

gh-119357: Increase test coverage for keymap in _pyrepl #119358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 4 commits into from
May 22, 2024
+94 −53
Merged

gh-119357: Increase test coverage for keymap in _pyrepl #119358

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7623575
Increase test coverage for keymap in _pyrepl
eugenetriguba May 21, 2024
45e01c2
Merge branch 'main' into gh-119357
eugenetriguba May 21, 2024
6986565
Fix mypy
ambv May 21, 2024
10a06f0
Merge branch 'main' into gh-119357
eugenetriguba May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix mypy
  • Loading branch information
@ambv
ambv committed May 21, 2024
commit 6986565e1ae53d7c2ee3340b01727639bd1c6853
18 changes: 9 additions & 9 deletions Lib/_pyrepl/keymap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,14 +108,14 @@ class KeySpecError(Exception):
def parse_keys(keys: str) -> list[str]:
"""Parse keys in keyspec format to a sequence of keys."""
s = 0
r = []
r: list[str] = []
while s < len(keys):
k, s = _parse_single_key_sequence(keys, s)
r.extend(k)
return r


def _parse_single_key_sequence(key: str, s: int) -> tuple[str, int]:
def _parse_single_key_sequence(key: str, s: int) -> tuple[list[str], int]:
ctrl = 0
meta = 0
ret = ""
Expand Down Expand Up @@ -150,11 +150,11 @@ def _parse_single_key_sequence(key: str, s: int) -> tuple[str, int]:
meta = 1
s += 3
elif c.isdigit():
n = key[s + 1: s + 4]
n = key[s + 1 : s + 4]
ret = chr(int(n, 8))
s += 4
elif c == "x":
n = key[s + 2: s + 4]
n = key[s + 2 : s + 4]
ret = chr(int(n, 16))
s += 4
elif c == "<":
Expand All @@ -164,7 +164,7 @@ def _parse_single_key_sequence(key: str, s: int) -> tuple[str, int]:
"unterminated \\< starting at char %d of %s"
% (s + 1, repr(key))
)
ret = key[s + 2: t].lower()
ret = key[s + 2 : t].lower()
if ret not in _keynames:
raise KeySpecError(
"unrecognised keyname `%s' at char %d of %s"
Expand All @@ -187,11 +187,11 @@ def _parse_single_key_sequence(key: str, s: int) -> tuple[str, int]:
ret = f"ctrl {ret}"
else:
raise KeySpecError("\\C- followed by invalid key")

result = [ret], s
if meta:
ret = ["\033", ret]
else:
ret = [ret]
return ret, s
result[0].insert(0, "\033")
return result


def compile_keymap(keymap, empty=b""):
Expand Down