Skip to content

gh-119247: Add macros to use PySequence_Fast safely in free-threaded build #119315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 9 commits into from
May 22, 2024
+106 −3
Merged

gh-119247: Add macros to use PySequence_Fast safely in free-threaded build #119315

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b22f6e2
Initial work on critical sections for fast sequences while developing…
MojoVampire May 21, 2024
2b4fe19
Test for efficacy of fast sequence locking macro on str.join, both te…
MojoVampire May 21, 2024
536defc
Blurb for change
MojoVampire May 21, 2024
0475c8e
Update Include/internal/pycore_critical_section.h
MojoVampire May 21, 2024
1f3cec0
Tweak comments per review
MojoVampire May 21, 2024
707852d
Use braced if per review
MojoVampire May 21, 2024
66f0e6c
Per review, refactor extend test to extend multiple times, and reduce…
MojoVampire May 21, 2024
515ee56
Remove listobject.h include per review (all users of pycore_critical_…
MojoVampire May 21, 2024
254a5a5
Reduce readers in test_racing_join_replace to 10, use Event to synchr…
MojoVampire May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Include/internal/pycore_critical_section.h 
Use braces to restrict scope of conditional locking

Co-authored-by: Sam Gross <colesbury@gmail.com>
  • Loading branch information
@MojoVampire @colesbury
MojoVampire and colesbury committed May 22, 2024
commit 0475c8eb410257559caee1a15664bacffb14528b
3 changes: 2 additions & 1 deletion Include/internal/pycore_critical_section.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,9 @@ extern "C" {
&_orig_seq->ob_mutex) \

# define Py_END_CRITICAL_SECTION_SEQUENCE_FAST() \
if (_should_lock_cs) \
if (_should_lock_cs) { \
_PyCriticalSection_End(&_cs); \
} \
}

// Asserts that the mutex is locked. The mutex must be held by the
Expand Down