Skip to content

gh-119292: Add job to jit.yml to build and test with --disable-gil #119293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 10 commits into from
May 21, 2024
+18 −0
Merged

gh-119292: Add job to jit.yml to build and test with --disable-gil #119293

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
18349bf
add jit and no gil ci job
savannahostrowski May 21, 2024
39b2a13
remove newlines;
savannahostrowski May 21, 2024
b05a1fe
comment out for testing
savannahostrowski May 21, 2024
7526af3
switch to ubuntu-latest
savannahostrowski May 21, 2024
5843011
uncomment and update text
savannahostrowski May 21, 2024
471e5eb
remove extraneous whitespace
savannahostrowski May 21, 2024
88e07d3
remove extraneous whitespace
savannahostrowski May 21, 2024
6b760d3
Update .github/workflows/jit.yml
savannahostrowski May 21, 2024
add9659
Update .github/workflows/jit.yml
savannahostrowski May 21, 2024
e50b538
Update jit.yml
savannahostrowski May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update .github/workflows/jit.yml 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
  • Loading branch information
@savannahostrowski @hugovk
savannahostrowski and hugovk authored May 21, 2024
commit add965946f6ebf83f69a98e16487e04b65659204
2 changes: 1 addition & 1 deletion .github/workflows/jit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ jobs:
- uses: actions/setup-python@v5
with:
python-version: '3.11'
- name: Build with JIT and GIL disabled
- name: Build with JIT enabled and GIL disabled
run: |
sudo bash -c "$(wget -O - https://apt.llvm.org/llvm.sh)" ./llvm.sh 18
export PATH="$(llvm-config-18 --bindir):$PATH"
Copy link
Copy Markdown
Member

@sobolevn sobolevn May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opinions: should we add --with-pydebug? Maybe test both modes?

Copy link
Copy Markdown
Member

@brandtbucher brandtbucher May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to leave this as-is (just one --with-pydebug build).

Expand Down