Skip to content

gh-118138: Adds test for multithreaded writes to files. #119107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elistevens wants to merge 4 commits into from
Closed

gh-118138: Adds test for multithreaded writes to files. #119107

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dca6eb6
Adds test for multithreaded writes to files.
elistevens May 17, 2024
997dbc2
Calls executor.shutdown before closing file.
elistevens May 17, 2024
3f05fd9
Fixes race conditions from multithreaded writes.
elistevens May 17, 2024
d156d3c
Update test_io_threading.py to not suffer from interleaved prints
elistevens May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update test_io_threading.py to not suffer from interleaved prints
  • Loading branch information
@elistevens
elistevens authored May 30, 2024
commit d156d3c73dca08032ffa0e6b8edc1080bebdcb38
4 changes: 2 additions & 2 deletions Lib/test/test_io_threading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
def looping_print_to_file(f, i):
for j in range(NUM_LOOPS):
# p = 'x' * 90 + '123456789'
p = f"{i:2}i,{j}j\n" + '0123456789' * 10
p = f"\n{i}i,{j}j\n" + '0123456789' * 10
print(p, file=f)

class IoThreadingTestCase(unittest.TestCase):
Expand All @@ -27,7 +27,7 @@ def test_io_threading(self):

for i in range(NUM_THREADS):
for j in range(NUM_LOOPS):
p = f"{i:2}i,{j}j"
p = f"{i}i,{j}j"

assert p in lines, repr(p)

Expand Down