Skip to content

gh-119049: Fix incorrect usage of GET_WARNINGS_ATTR #119063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 8 commits into from
May 16, 2024
Merged

gh-119049: Fix incorrect usage of GET_WARNINGS_ATTR #119063

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
88b9e20
gh-119049: Fix incorrect display of warning which is constructed by C…
Eclips4 May 15, 2024
f6da005
Change name
Eclips4 May 15, 2024
ee4dca9
Add a test case with finalization
Eclips4 May 16, 2024
fcc49ed
Update test case
Eclips4 May 16, 2024
f75f5cb
Update Lib/test/test_capi/test_exceptions.py
Eclips4 May 16, 2024
86dda91
Address review
Eclips4 May 16, 2024
7337245
too long line
Eclips4 May 16, 2024
b53c6ed
Add a NEWS entry.
serhiy-storchaka May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review
  • Loading branch information
@Eclips4
Eclips4 committed May 16, 2024
commit 86dda917b3ab8ce28d67f219f9c6c3bdfe999f95
7 changes: 4 additions & 3 deletions Lib/test/test_capi/test_exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,17 +95,18 @@ def test_warn_during_finalization(self):
import _testcapi

class Foo:
def __del__(self):
def foo(self):
_testcapi.function_set_warning()
def __del__(self):
self.foo()

ref = Foo()
''')
proc = assert_python_ok("-c", code)
warnings = proc.err.splitlines()
# Due to the finalization of the interpreter, the source will be ommited
# because the ``warnings`` module cannot be imported at this time
self.assertEqual(len(warnings), 1)
self.assertEqual(warnings[0], b'<sys>:0: RuntimeWarning: Testing PyErr_WarnEx')
self.assertEqual(warnings, [b'<string>:7: RuntimeWarning: Testing PyErr_WarnEx'])


class Test_FatalError(unittest.TestCase):
Expand Down